Web: shared entity components — kill the render forks #129

New issue

Closed

opened 2026-08-18 10:45:24 +00:00 by nalum · 0 comments

nalum commented

2026-08-18 10:45:24 +00:00

Owner

From the surface parity report (2026-08-18), section 5.1 and consolidation targets 1, 3, 4, 5, 6, 10.

No entity card/row is defined once on the web. Jobs render at 12 sites; the Today card vs Jobs card fork drops four features (repeat glyph, description, due label, take) and duplicates the "Worth N points" sentence under two message ids. The due label exists in 4 incompatible formats. deadlineLabel, isOverdue and byDeadline are byte-identical duplicates in Today.tsx and Jobs.tsx.

Targets:

Extract JobCard into components/ with a variant/flag; Today and Jobs consume it. This is the component work behind #107.
One deadline.ts (label, overdue, sort, timed predicate); delete the copies and the three Calendar formats.
One points.ts (single formatter, single clamped ledger) — closes the negative-balance inconsistency.
A MemberSelect component (mark-option grid + sentinel-label prop) — replaces 13 copies.
repeatLabel unified on the Intl path.
Add the rule to AGENTS.md: an entity rendered on more than one board must render through one exported component per surface.

Also from 5.1: Today bypasses timeRange() for a local eventTime() (the same event reads "14:00" vs "14:00 – 15:30"), FamilyTree.tsx:443 re-implements <Mark> as raw SVG, ProfileSwitchPanel.tsx:140 bypasses markColorVar(), the "Dinner" fallback is written 5 times, and Today's dinner strip wears the rewards .reward-strip class.

From the surface parity report (2026-08-18), section 5.1 and consolidation targets 1, 3, 4, 5, 6, 10. No entity card/row is defined once on the web. Jobs render at 12 sites; the Today card vs Jobs card fork drops four features (repeat glyph, description, due label, take) and duplicates the "Worth N points" sentence under two message ids. The due label exists in 4 incompatible formats. `deadlineLabel`, `isOverdue` and `byDeadline` are byte-identical duplicates in Today.tsx and Jobs.tsx. Targets: 1. Extract `JobCard` into `components/` with a variant/flag; Today and Jobs consume it. This is the component work behind #107. 2. One `deadline.ts` (label, overdue, sort, timed predicate); delete the copies and the three Calendar formats. 3. One `points.ts` (single formatter, single clamped ledger) — closes the negative-balance inconsistency. 4. A `MemberSelect` component (mark-option grid + sentinel-label prop) — replaces 13 copies. 5. `repeatLabel` unified on the `Intl` path. 6. Add the rule to AGENTS.md: an entity rendered on more than one board must render through one exported component per surface. Also from 5.1: Today bypasses `timeRange()` for a local `eventTime()` (the same event reads "14:00" vs "14:00 – 15:30"), `FamilyTree.tsx:443` re-implements `<Mark>` as raw SVG, `ProfileSwitchPanel.tsx:140` bypasses `markColorVar()`, the "Dinner" fallback is written 5 times, and Today's dinner strip wears the rewards `.reward-strip` class.

nalum added the

enhancement

web

tracking

labels

2026-08-18 10:45:24 +00:00

nalum referenced this issue

2026-08-18 11:22:44 +00:00

Order of work for the open backlog (#107–#136) #137

nalum referenced this issue from a commit

2026-08-18 14:07:53 +00:00

refactor(web): one deadline module for every due rendering