Jobs: add the design token roles the new job flow needs #170
Labels
No labels
adr
android
area/calendar
area/design-system
area/i18n
area/jobs
area/offline
area/server
area/testing
bug
ci
duplicate
enhancement
help wanted
invalid
notifications
question
reliability
security
severity/low
severity/medium
tracking
web
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
eagraiclainne/app#170
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of the jobs flow redesign. The design handoff (
design_handoff_jobs_flow, held outside the repo) is the source; the facts it depends on are repeated here so this issue stands alone.design/tokens.yamlships nine roles per mode:surface,card,ink,ink-soft,accent,on-accent,celebrate,danger,line. The job flow needs about fifteen. Five of the nine map across (accent,on-accent,ink,lineas the hairline,celebrateas the reward mark). The rest are new:surface-raised— the in-place edit fillsurface-sunken— sheet footerborderandborder-strong— control outline, unticked checkbox and empty pipinkandink-softerroranderror-surface— the invalid row ringdestructiveandon-destructive— the delete buttonEach role is 19 themes by 2 modes, and
cmd/tokengenhard-fails any pair below WCAG AA 4.5:1, so every value is authored, not derived by hand. Runmake tokensand keepmake tokens-checkgreen.Two corrections to carry over from the design review: sheet and card radius read the per-theme
radiustoken (hearth 12, meadow 22) rather than the fixed 26/16-22 the prototypes draw, and the prototype's Meadow mapping is off by one level, so re-derive it fromtokens.yaml.Blocks the row grammar, which cannot be built without
surface-raised,border-strongand the error pair.Update — the late state needs a tenth role
The design handoff added a late state (#174), and the checklist requires it to
be amber. The palette has no amber but
celebrate, which means reward andcelebration. Sharing it would put two meanings on one token — the same fault
the design rejects for the accent left rail.
So either a tenth role (
late/warning, 19 themes by 2 modes through the AAgate) or an explicit, written decision to share
celebrateand accept thecollision. Decide here, before the card is built: the row grammar needs the
first six roles, and #174 cannot be built without the amber.
Update — decided: a tenth role,
warning, with an iconSo the role is
warningrather than a jobs-only "late" — it names the state, notthe surface, which lets the calendar and any later surface use it without a
second token.
The icon needs no font work: ⚠ is already in the bundled Eagrai Symbols subset
(
web/src/fonts/README.md), so the glyph resolves on both surfaces today. Pairit with an
on-warningink if the design uses the role as a fill anywhere; thegenerator's AA gate gets the final say on both.
Late state usage lives in #174 and #186 — glyph, colour and word together, never
colour alone.
Add a tenth role, it should be a warning with matching icon.