eagraiclainne/app

Watch

Fork 0

fix(item): deleting a job frees its unclaimed rewards #185

Merged

nalum merged 4 commits from fix/delete-frees-unclaimed-rewards into main

2026-08-26 18:32:41 +00:00

nalum commented

2026-08-23 21:57:07 +00:00

Owner

Unlinking now runs inside the delete transaction, over the job and over each
cascaded sub-job, on the same locked-read then write path the completion
auto-claim uses. A claimed reward keeps its link: it is settled ledger
history, the points are already banked to whoever earned them, and ADR-0015
refuses to relink one anyway. Banked points are untouched either way.

The live data feed hears about the freed rows after the commit, since they
move without the svc seams.

Why now

This is the one server change the jobs flow redesign needs (#184, step 0). The
delete dialog tells the household "the 22 points reward goes back to the
rewards list" — that sentence is only true after this lands, so #176 depends
on it.

Verification

Two integration specs in item_integration_test.go: unclaimed rewards on the
job and on a sub-job come back unlinked and relink to another job with no
unlink first; a banked reward keeps its link, its claim and its value.
make check and make test-integration both green.

One thing the specs surfaced and now record: Claim refuses a linked reward
outright ("this reward is earned by completing its linked job"), so completion
is the only door to the banked state.

Closes nothing on its own — see #184 for the flow this unblocks.

🤖 Generated with Claude Code

Deleting a job left every unclaimed reward linked to it pointing at a row that no longer exists. Every eligibility filter — client and server — skips a reward that already has an item, so the reward was not returned to the pool. It was destroyed, with no message and no way back. Unlinking now runs inside the delete transaction, over the job and over each cascaded sub-job, on the same locked-read then write path the completion auto-claim uses. A claimed reward keeps its link: it is settled ledger history, the points are already banked to whoever earned them, and ADR-0015 refuses to relink one anyway. Banked points are untouched either way. The live data feed hears about the freed rows after the commit, since they move without the `svc` seams. ## Why now This is the one server change the jobs flow redesign needs (#184, step 0). The delete dialog tells the household "the 22 points reward goes back to the rewards list" — that sentence is only true after this lands, so #176 depends on it. ## Verification - Two integration specs in `item_integration_test.go`: unclaimed rewards on the job and on a sub-job come back unlinked and relink to another job with no unlink first; a banked reward keeps its link, its claim and its value. - `make check` and `make test-integration` both green. One thing the specs surfaced and now record: `Claim` refuses a linked reward outright ("this reward is earned by completing its linked job"), so completion is the only door to the banked state. Closes nothing on its own — see #184 for the flow this unblocks. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added the

bug

severity/medium

labels

2026-08-23 21:57:07 +00:00

nalum added 1 commit

2026-08-23 21:57:07 +00:00

fix(item): deleting a job frees its unclaimed rewards

check / commits (pull_request) Successful in 21s

Details

check / web (pull_request) Successful in 6m11s

Details

check / go (pull_request) Failing after 2m20s

Details

check / report (pull_request) Successful in 3s

Details

a7819ecbcd

A points reward linked to a deleted job kept pointing at the dead row,
and every eligibility filter excludes a reward whose item.uid is
non-empty — so the reward was not returned to the pool, it was lost.
Nothing could relink it and nothing could claim it.

Unlinking runs inside the delete transaction, over the job and over each
cascaded sub-job, on the same locked-read/write path the auto-claim uses.
Claimed rewards keep their link: they are settled ledger history, banked
points survive the job, and ADR-0015 already refuses to relink them.

nalum referenced this pull request

2026-08-23 21:58:05 +00:00

Jobs: the delete dialog and the chain-end states #176

nalum referenced this pull request

2026-08-23 21:58:06 +00:00

Order of work for the jobs flow redesign (#170-#183) #184

forgejo-actions commented

2026-08-23 22:00:56 +00:00

Test report

Suite	Tests	Result	Skipped
Unit	1373	✅ pass	1
Integration	90	✅ pass	—

Coverage: 26.7%

_{Updated by the check workflow · commit 7ca62a0a2b}

## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1373 | ✅ pass | 1 | | Integration | 90 | ✅ pass | — | **Coverage:** 26.7% <sub>Updated by the check workflow · commit 7ca62a0a2bc70ed17ccb3a818020eb665d7d98c6</sub>

nalum added the

area/jobs

area/server

labels

2026-08-23 22:57:23 +00:00

nalum referenced this pull request

2026-08-24 08:18:00 +00:00

docs: bring in the design handoff docs #200

nalum force-pushed fix/delete-frees-unclaimed-rewards from a7819ecbcd

check / commits (pull_request) Successful in 21s

Details

check / web (pull_request) Successful in 6m11s