Calendar: month view, desktop grid and phone dots #190
Labels
No labels
adr
android
area/calendar
area/design-system
area/i18n
area/jobs
area/offline
area/server
area/testing
bug
ci
duplicate
enhancement
help wanted
invalid
notifications
question
reliability
security
severity/low
severity/medium
tracking
web
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
eagraiclainne/app#190
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of the calendar redesign. The design handoff (
design_handoff_calendar, held outside the repo) is the source; the facts it depends on are repeated here so this issue stands alone.Desktop is a hairline grid, not floating cards. The shipped 8px gutters between rounded cells break the column reading a month grid exists for, and cost roughly a line of text per cell.
15:0...is worse than none. Where the time is the point, it rides in the title.3 moreand opens the day sheet.Phone is the only genuinely new visual language in this bundle. At 390px a week column is 47px, so the grid stops pretending to hold content: a date and up to three dots.
Two requirements added after #213 shipped
The job sheet went out to the family's cluster three times before it was right.
Seven visual defects, none caught by a suite: pickers that unfolded forms
instead of opening, three Save buttons on a commit-on-blur screen,
(optional)labels, a reward's name used as a field label, an unstyled add row, checkboxes
with a ghosted tick, and a create form with a browser spinner. Every one had to
be found by a person looking at a screen.
1. Screenshot goldens are part of this ticket
Record gallery (Playwright) and Roborazzi cases for every surface this ticket
builds or visibly changes, and treat them as a deliverable rather than a
follow-up. Three of #213's defects — the unstyled add row, the ghosted
checkboxes, the spinner in the create form — were pixel faults that a golden
would have caught before a deploy did.
#172deferred its goldens on the reasoning that later tickets would re-recordthem. That reasoning was sound then and is not now: the row grammar and the
pickers are settled, so an image recorded here stays valid.
Mechanics, from AGENTS.md: a new case rides in the same commit as the code
that adds it — a commit that adds a gallery or Roborazzi case without its image
is red on its own, because
check / webrunsnpm run test:screensandandroid / buildrunsverifyRoborazziDebug. A re-recorded existing casegoes in its own commit, so the reviewable diff stays code.
2. Check for leaked form styling before you finish
Every visual defect on #213 came from one place: the shipped app's form
fragments reused inside the new row grammar. They pass every test, because the
tests assert the pieces exist rather than that the screen reads right.
Before you call this done, grep the surfaces you touched and report what you
found and what you did about each:
<input>/OutlinedTextField/BasicTextFieldoutside the row andpicker components — a form field dropped into a list of rows
type="number", which renders browser spinner arrowsbtn,link-btn,btn-quietorTextButtonwhere a row or a quiet rowverb belongs — underlined links reading as broken text
(optional)in any label — §8 names that pattern as the form admitting itshould not have asked
Save changesandSave the pointslabel— that column is for afield's name (
Who,When,Worth), and a long title wraps in itIf your ticket is the first to land after this was written, add the check to
AGENTS.md beside the goldens rule, so it stops being a thing I remember to say.
Update — the locked demo supersedes the per-row heights (2026-08-25)
calendar-demo.dc.htmlis now the design to build from, and it changes one rule above: every week row in the month is the same height, sized to the busiest day in the month (the demo tiers it — 96px when the month is empty, 112px light, 132px busy), and the date sits in the same top-left spot in every cell. Today's date is a filled accent pill in that spot with the word Today beside it, not an extra line above the content. The "empty weeks collapse to 74px" sentence above is stale; the handoff's acceptance checklist and the demo agree on uniform rows.Phone month, from the demo: a birthday takes a dot slot with the cake (the cap beside it drops to two); unowned jobs draw the hollow dot; soloed to one person the dots count that person's items with fading opacity; past the cap the last slot is the split-colour lozenge. Day content below the grid, full-width rows, unchanged.
Delivered in PR #260: the desktop hairline month (uniform week-row heights by the busiest day) and the phone dot month, with the dot rule pure and pinned cross-surface by conformance/calendar-dots.json (web/src/calmonth.ts, CalMonth.kt).
Delivered by PR #260 (hairline month grid + phone dots, calendar-dots.json), merged to main 2026-08-26.