Calendar: the day sheet #191
Labels
No labels
adr
android
area/calendar
area/design-system
area/i18n
area/jobs
area/offline
area/server
area/testing
bug
ci
duplicate
enhancement
help wanted
invalid
notifications
question
reliability
security
severity/low
severity/medium
tracking
web
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
eagraiclainne/app#191
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of the calendar redesign. The design handoff (
design_handoff_calendar, held outside the repo) is the source; the facts it depends on are repeated here so this issue stands alone.The shipped sheet spends about 1,400px of ruled hour axis to show one dinner, and puts the day's untimed jobs in an unlabelled strip above the rule with no tick box.
No time set · 3 jobs), each row carrying its tick box. A due date may or may not carry a time, so that split is the day's real structure.nothing until 16:00 · 6 hours— expandable, withShow all 24 hoursfor anyone dragging times about.One open question to settle while building: whether the sheet's add action offers both types or only events. A job created here needs an owner, which is a second decision the sheet does not currently ask.
Two requirements added after #213 shipped
The job sheet went out to the family's cluster three times before it was right.
Seven visual defects, none caught by a suite: pickers that unfolded forms
instead of opening, three Save buttons on a commit-on-blur screen,
(optional)labels, a reward's name used as a field label, an unstyled add row, checkboxes
with a ghosted tick, and a create form with a browser spinner. Every one had to
be found by a person looking at a screen.
1. Screenshot goldens are part of this ticket
Record gallery (Playwright) and Roborazzi cases for every surface this ticket
builds or visibly changes, and treat them as a deliverable rather than a
follow-up. Three of #213's defects — the unstyled add row, the ghosted
checkboxes, the spinner in the create form — were pixel faults that a golden
would have caught before a deploy did.
#172deferred its goldens on the reasoning that later tickets would re-recordthem. That reasoning was sound then and is not now: the row grammar and the
pickers are settled, so an image recorded here stays valid.
Mechanics, from AGENTS.md: a new case rides in the same commit as the code
that adds it — a commit that adds a gallery or Roborazzi case without its image
is red on its own, because
check / webrunsnpm run test:screensandandroid / buildrunsverifyRoborazziDebug. A re-recorded existing casegoes in its own commit, so the reviewable diff stays code.
2. Check for leaked form styling before you finish
Every visual defect on #213 came from one place: the shipped app's form
fragments reused inside the new row grammar. They pass every test, because the
tests assert the pieces exist rather than that the screen reads right.
Before you call this done, grep the surfaces you touched and report what you
found and what you did about each:
<input>/OutlinedTextField/BasicTextFieldoutside the row andpicker components — a form field dropped into a list of rows
type="number", which renders browser spinner arrowsbtn,link-btn,btn-quietorTextButtonwhere a row or a quiet rowverb belongs — underlined links reading as broken text
(optional)in any label — §8 names that pattern as the form admitting itshould not have asked
Save changesandSave the pointslabel— that column is for afield's name (
Who,When,Worth), and a long title wraps in itIf your ticket is the first to land after this was written, add the check to
AGENTS.md beside the goldens rule, so it stops being a thing I remember to say.
Update — the open question is closed, and the demo locks the sheet (2026-08-25)
Events only. A job needs an owner, and that decision belongs on the jobs board — so every create affordance in the calendar (the day sheet's primary, the toolbar +, the hour add-targets, the agenda's empty-day link) reads New event and says so. Nobody hunts for a job option that was never there.
From the locked
calendar-demo.dc.html: the header carries ‹ › day-steppers (44px, the date in the tooltip) and a summary line (3 things · 2 people · today); untimed items sit first underNo time setwith a count; the timed axis sits underThrough the daywithShow all 24 hours/Collapse the quiet hours; gaps readnothing until 16:00 · 6 hours(ornothing after 21:00) and expand in place; empty hours are+ add at 09:00targets; the footer isNew event on this daybeside a day⋯holding New event on this day and Show all 24 hours.Delivered in PR #261: the §2.7 day sheet — untimed first (birthdays, dinner), the timed axis below, one CalendarItemRow grammar throughout, tick as a full completion site.
Delivered by PR #261 (day sheet — untimed first, the axis collapses), merged to main 2026-08-26.