Calendar: regroup the toolbar by grammar

nalum commented

2026-08-23 22:54:07 +00:00

Owner

Part of the calendar redesign. The design handoff (design_handoff_calendar, held outside the repo) is the source; the facts it depends on are repeated here so this issue stands alone.

The shipped toolbar is seven controls in one row in three grammars — who (four chips), what (three chips), when and how (five circles). On a phone that eats 380px, 45% of the viewport, before a date appears. It also shows two selected states that read as one choice (Everyone outlined-green, Everything filled-green) and two calendar icons, 130px apart, meaning "today" and "month".

Regrouped:

Who — member avatars, 34px on desktop and 36px on the phone, tap to solo. No chip labels once the mark is legible.
What — one segmented control: All / Events / Jobs.
When — <, a Today icon (a drawn calendar box with today's date inside it, not an emoji glyph over a numeral), >.
How — one segmented control: Month / Week / Agenda.

One selected style throughout. Two rows become one on desktop, and about 130px on the phone instead of 380px. There is exactly one Today control and it is an icon.

Two requirements added after #213 shipped

The job sheet went out to the family's cluster three times before it was right.
Seven visual defects, none caught by a suite: pickers that unfolded forms
instead of opening, three Save buttons on a commit-on-blur screen, (optional)
labels, a reward's name used as a field label, an unstyled add row, checkboxes
with a ghosted tick, and a create form with a browser spinner. Every one had to
be found by a person looking at a screen.

1. Screenshot goldens are part of this ticket

Record gallery (Playwright) and Roborazzi cases for every surface this ticket
builds or visibly changes, and treat them as a deliverable rather than a
follow-up. Three of #213's defects — the unstyled add row, the ghosted
checkboxes, the spinner in the create form — were pixel faults that a golden
would have caught before a deploy did.

#172 deferred its goldens on the reasoning that later tickets would re-record
them. That reasoning was sound then and is not now: the row grammar and the
pickers are settled, so an image recorded here stays valid.

Mechanics, from AGENTS.md: a new case rides in the same commit as the code
that adds it — a commit that adds a gallery or Roborazzi case without its image
is red on its own, because check / web runs npm run test:screens and
android / build runs verifyRoborazziDebug. A re-recorded existing case
goes in its own commit, so the reviewable diff stays code.

2. Check for leaked form styling before you finish

Every visual defect on #213 came from one place: the shipped app's form
fragments reused inside the new row grammar. They pass every test, because the
tests assert the pieces exist rather than that the screen reads right.

Before you call this done, grep the surfaces you touched and report what you
found and what you did about each:

a raw <input> / OutlinedTextField / BasicTextField outside the row and
picker components — a form field dropped into a list of rows
type="number", which renders browser spinner arrows
btn, link-btn, btn-quiet or TextButton where a row or a quiet row
verb belongs — underlined links reading as broken text
(optional) in any label — §8 names that pattern as the form admitting it
should not have asked
any Save button on a surface that commits on blur, including Save changes and Save the points
a disabled-and-grey control where law 5 wants it absent
a record's title used as a field row's label — that column is for a
field's name (Who, When, Worth), and a long title wraps in it

If your ticket is the first to land after this was written, add the check to
AGENTS.md beside the goldens rule, so it stops being a thing I remember to say.

Update — the demo settles the who-filter and the ＋ (2026-08-25)

The who-filter scales by roster, not by breakpoint: hidden at one member (nobody to filter to), every avatar inline at two to five, horizontally scrolling at six or more with Everyone pinned outside the scroller — the escape from a filter is never the thing you have to scroll to find.
＋ New event lives in the toolbar — labelled on desktop, a 44px ＋ on the phone — and targets the day in focus. Every create affordance in the calendar reads New event.
One nuance the locked demo draws: the What filter's selected state is accent-filled while the view switcher's is neutral — a filter changes what you see, a view changes how. If that reads against "one selected style" during build, resolve toward the demo.

Part of the calendar redesign. The design handoff (`design_handoff_calendar`, held outside the repo) is the source; the facts it depends on are repeated here so this issue stands alone. The shipped toolbar is seven controls in one row in three grammars — who (four chips), what (three chips), when and how (five circles). On a phone that eats 380px, 45% of the viewport, before a date appears. It also shows two selected states that read as one choice (*Everyone* outlined-green, *Everything* filled-green) and two calendar icons, 130px apart, meaning "today" and "month". Regrouped: - **Who** — member avatars, 34px on desktop and 36px on the phone, tap to solo. No chip labels once the mark is legible. - **What** — one segmented control: `All` / `Events` / `Jobs`. - **When** — `<`, a Today icon (a drawn calendar box with today's date inside it, not an emoji glyph over a numeral), `>`. - **How** — one segmented control: `Month` / `Week` / `Agenda`. One selected style throughout. Two rows become one on desktop, and about 130px on the phone instead of 380px. There is exactly one Today control and it is an icon. --- ## Two requirements added after #213 shipped The job sheet went out to the family's cluster three times before it was right. Seven visual defects, none caught by a suite: pickers that unfolded forms instead of opening, three Save buttons on a commit-on-blur screen, `(optional)` labels, a reward's name used as a field label, an unstyled add row, checkboxes with a ghosted tick, and a create form with a browser spinner. Every one had to be found by a person looking at a screen. ### 1. Screenshot goldens are part of this ticket Record gallery (Playwright) and Roborazzi cases for every surface this ticket builds or visibly changes, and treat them as a deliverable rather than a follow-up. Three of #213's defects — the unstyled add row, the ghosted checkboxes, the spinner in the create form — were pixel faults that a golden would have caught before a deploy did. `#172` deferred its goldens on the reasoning that later tickets would re-record them. That reasoning was sound then and is not now: the row grammar and the pickers are settled, so an image recorded here stays valid. Mechanics, from AGENTS.md: a **new** case rides in the same commit as the code that adds it — a commit that adds a gallery or Roborazzi case without its image is red on its own, because `check / web` runs `npm run test:screens` and `android / build` runs `verifyRoborazziDebug`. A **re-recorded existing** case goes in its own commit, so the reviewable diff stays code. ### 2. Check for leaked form styling before you finish Every visual defect on #213 came from one place: the shipped app's form fragments reused inside the new row grammar. They pass every test, because the tests assert the pieces exist rather than that the screen reads right. Before you call this done, grep the surfaces you touched and report what you found and what you did about each: - a raw `<input>` / `OutlinedTextField` / `BasicTextField` outside the row and picker components — a form field dropped into a list of rows - `type="number"`, which renders browser spinner arrows - `btn`, `link-btn`, `btn-quiet` or `TextButton` where a row or a quiet row verb belongs — underlined links reading as broken text - `(optional)` in any label — §8 names that pattern as the form admitting it should not have asked - **any Save button on a surface that commits on blur**, including `Save changes` and `Save the points` - a disabled-and-grey control where law 5 wants it absent - a record's title used as a field row's `label` — that column is for a field's name (`Who`, `When`, `Worth`), and a long title wraps in it If your ticket is the first to land after this was written, add the check to AGENTS.md beside the goldens rule, so it stops being a thing I remember to say. --- ## Update — the demo settles the who-filter and the ＋ (2026-08-25) - **The who-filter scales by roster, not by breakpoint:** hidden at one member (nobody to filter to), every avatar inline at two to five, horizontally scrolling at six or more with *Everyone* pinned outside the scroller — the escape from a filter is never the thing you have to scroll to find. - **＋ New event lives in the toolbar** — labelled on desktop, a 44px ＋ on the phone — and targets the day in focus. Every create affordance in the calendar reads *New event*. - One nuance the locked demo draws: the What filter's selected state is accent-filled while the view switcher's is neutral — a filter changes *what* you see, a view changes *how*. If that reads against "one selected style" during build, resolve toward the demo.

nalum added the

enhancement

android

web

labels

2026-08-23 22:54:07 +00:00

nalum referenced this issue

2026-08-23 22:54:30 +00:00

Order of work for the calendar redesign (#187-#198) #199

nalum added the

area/calendar

label

2026-08-23 22:57:22 +00:00

nalum referenced this issue

2026-08-26 00:05:39 +00:00

feat(calendar): month view — the hairline grid and the phone dots #260

nalum referenced this issue from a commit

2026-08-26 02:20:05 +00:00

feat(calendar): agenda and week views, web

nalum referenced this issue from a commit

2026-08-26 03:23:33 +00:00

feat(calendar): the toolbar regrouped by grammar, web

nalum referenced this issue from a pull request that will close it,

2026-08-26 03:23:45 +00:00

feat(calendar): the toolbar regrouped by grammar (#197) #265

nalum commented

2026-08-26 03:24:28 +00:00

Author

Owner

Delivered in PR #265: the toolbar regrouped by grammar on both surfaces — ‹ ⊡ › when-cluster with the drawn today-box, tap-to-solo member marks with Everyone pinned outside the scroller, What segmented in the accent, How segmented neutral, ＋ New event in the row targeting the day in focus.

nalum referenced this issue

2026-08-26 03:24:40 +00:00

Order of work for the calendar redesign (#187-#198) #199

nalum referenced this issue from a commit

2026-08-26 03:45:44 +00:00

feat(calendar): agenda and week views, web

nalum referenced this issue from a commit

2026-08-26 03:45:52 +00:00

feat(calendar): the toolbar regrouped by grammar, web

nalum referenced this issue from a commit

2026-08-26 04:32:41 +00:00

feat(calendar): agenda and week views, web