eagraiclainne/app

Watch

Fork 0

docs(proto): occurrence_date is a local date, not a UTC key #203

Merged

nalum merged 1 commit from docs/occurrence-date-zone into main

2026-08-26 18:32:54 +00:00

nalum commented

2026-08-24 09:16:18 +00:00

Owner

Closes #198.

The comment on Event.occurrence_date called the slot key UTC. It never
was. domain.ExpandEventOccurrences formats it from a time already
converted into the zone the request carried, and validSlot parses it back
with ParseInLocation against that same zone.

A client that believed the comment would compute the key in UTC and,
anywhere east or west of it, address a different day — splitting or
cancelling the wrong occurrence. The new wording also keeps the key apart
from Event.time_zone, which is a real but unrelated field the reminder
ticker reads.

Comment only, plus the regenerated artifacts that carry it.

🤖 Generated with Claude Code

Closes #198. The comment on `Event.occurrence_date` called the slot key UTC. It never was. `domain.ExpandEventOccurrences` formats it from a time already converted into the zone the request carried, and `validSlot` parses it back with `ParseInLocation` against that same zone. A client that believed the comment would compute the key in UTC and, anywhere east or west of it, address a different day — splitting or cancelling the wrong occurrence. The new wording also keeps the key apart from `Event.time_zone`, which is a real but unrelated field the reminder ticker reads. Comment only, plus the regenerated artifacts that carry it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit

2026-08-24 09:16:18 +00:00

docs(proto): occurrence_date is a local date, not a UTC key

check / commits (pull_request) Successful in 7s

Details

check / go (pull_request) Successful in 2m44s

Details

android / build (pull_request) Successful in 6m33s

Details

check / web (pull_request) Successful in 4m33s

Details

check / report (pull_request) Successful in 6s

Details

android / report (pull_request) Successful in 5s

Details

09451c05cc

The comment claimed the occurrence slot was UTC. It never was: the key is
formatted from a time already converted into the zone the request carried,
and validSlot parses it back with ParseInLocation against that same zone.
A client that believed the comment would compute the key in UTC and,
anywhere east or west of it, address a different day — splitting or
cancelling the wrong occurrence.

Naming the request's zone also keeps it apart from Event.time_zone, which
is a real but unrelated field the reminder ticker reads.

nalum added the

area/calendar

area/server

enhancement

labels

2026-08-24 09:16:18 +00:00

forgejo-actions commented

2026-08-24 09:44:48 +00:00

Test report

Suite	Tests	Result	Skipped
Unit	1373	✅ pass	1
Integration	90	✅ pass	—

Coverage: 26.7%

_{Updated by the check workflow · commit b074c386a8}

## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1373 | ✅ pass | 1 | | Integration | 90 | ✅ pass | — | **Coverage:** 26.7% <sub>Updated by the check workflow · commit b074c386a8cbcf649e3426697f023006e6ae62fe</sub>

forgejo-actions commented

2026-08-24 09:44:55 +00:00

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	43	✅ pass	0

Coverage: 3.0% of lines

_{Updated by the android workflow · commit b074c386a8}

## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 43 | ✅ pass | 0 | **Coverage:** 3.0% of lines <sub>Updated by the android workflow · commit b074c386a8cbcf649e3426697f023006e6ae62fe</sub>

nalum referenced this pull request

2026-08-25 22:20:34 +00:00

occurrence_date is documented as a UTC key but is a local date in the request's zone #198

nalum referenced this pull request

2026-08-25 22:20:34 +00:00

Order of work for the calendar redesign (#187-#198) #199

nalum force-pushed docs/occurrence-date-zone from 09451c05cc

check / commits (pull_request) Successful in 7s

Details

check / go (pull_request) Successful in 2m44s

Details

android / build (pull_request) Successful in 6m33s