A job owner has no way to nudge the people holding its open sub-jobs #217
Labels
No labels
adr
android
area/calendar
area/design-system
area/i18n
area/jobs
area/offline
area/server
area/testing
bug
ci
duplicate
enhancement
help wanted
invalid
notifications
question
reliability
security
severity/low
severity/medium
tracking
web
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
eagraiclainne/app#217
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The job card's waiting state needs an action the server cannot perform yet.
Where it comes from
build-review-01.mdandspec-rail-colour.mdin the jobs handoff both specifythe waiting card's action row as an outline
Nudge everyoneplus⋯. §4c'scard is the one a job owner sees when their own sub-jobs are ticked and other
people still hold open ones — the owner has nothing left to do but ask.
Every other card state has a primary action. Waiting is the only one whose
action does not exist, so today it either ships with a dead row or with no row,
and neither is what the design asks for.
What is missing
There is no nudge anywhere in the server.
internal/notifyhasJobDue,JobOverdue,JobAssigned,JobCompletedand the event reminders — all ofthem board-initiated, rung by the reminder ticker with no actor. Nothing
lets one household member deliberately prompt another, on any surface.
So this needs, at minimum:
ItemService— something likeNudgeSubTasks(item_uid)— thatfinds the job's open sub-jobs and notifies whoever holds them;
PermissionMatrixentry, or the completeness test fails the build;§4c is the owner's state. Decide whether a manager may nudge someone else's
job, and whether a child may nudge at all;
NotificationKindvalue — added, never renumbered (ADR-0035) — plus itscopy in
internal/notify/locales/*.json, six locales;time it is pressed is a button that gets pressed twice. The daily-claim shape
the reminder ticker already uses (
due_reminder_sent) is the nearestprecedent — one nudge per job per day is probably right.
Decisions worth taking with it
names? The design's
Nudge everyoneimplies all of them.a board reminder, and the notify seam currently distinguishes the two.
Waiting on Alistate with no action; it is the natural second home.Blocked behind it
The waiting card's action row. Until this exists, that card carries
⋯alone —which is honest, and better than a button that cannot do what it says.