§4d's plain-panel ladder can never reach its third rung on an owned job #236

New issue

Open

opened 2026-08-25 02:20:52 +00:00 by nalum · 0 comments

nalum commented

2026-08-25 02:20:52 +00:00

Owner

JobCard.tsx's plain panel (a job with no sub-jobs) documents a three-rung
fallback ladder — description → owner → repeat rule — and delivers two.

} else if (job.description !== "") {   // rung 1
} else if (ownerUid !== "") {          // rung 2 — always true here
} else if (repeatText !== null) {      // rung 3 — unreachable

The chain is only entered when the job is not up-for-grabs, which means
ownerUid !== "" — precisely rung 2's own condition. Rung 3 can never be tried.

What a household sees: a repeating chore with no description, on your own
board, shows Who it's for: <you> — telling you something the board already
told you — where the repeat cadence would be the more useful thing to say when
there is nothing else.

The repeat-rule fallback does render, but only in the up-for-grabs branch, as the
second rung of a different two-rung ladder (description → repeat).

The decision

Either the comment is wrong and should describe the real ladders, or the owner
rung should defer to the repeat text when the reader already knows whose job it
is. That is a design call rather than a tidy-up, which is why the code was left
alone.

Worth noting the ladder was pinned by fixtures and goldens throughout the card
work and neither caught this: no case exercises an owned, repeating, undescribed
job with no sub-jobs, because the unreachable branch meant no expected output
ever differed.

`JobCard.tsx`'s plain panel (a job with no sub-jobs) documents a three-rung fallback ladder — **description → owner → repeat rule** — and delivers two. ``` } else if (job.description !== "") { // rung 1 } else if (ownerUid !== "") { // rung 2 — always true here } else if (repeatText !== null) { // rung 3 — unreachable ``` The chain is only entered when the job is not up-for-grabs, which means `ownerUid !== ""` — precisely rung 2's own condition. Rung 3 can never be tried. **What a household sees**: a repeating chore with no description, on your own board, shows `Who it's for: <you>` — telling you something the board already told you — where the repeat cadence would be the more useful thing to say when there is nothing else. The repeat-rule fallback does render, but only in the up-for-grabs branch, as the second rung of a different two-rung ladder (description → repeat). ## The decision Either the comment is wrong and should describe the real ladders, or the owner rung should defer to the repeat text when the reader already knows whose job it is. That is a design call rather than a tidy-up, which is why the code was left alone. Worth noting the ladder was pinned by fixtures and goldens throughout the card work and neither caught this: no case exercises an owned, repeating, undescribed job with no sub-jobs, because the unreachable branch meant no expected output ever differed.

nalum added the

bug

severity/low

area/jobs

labels

2026-08-25 02:20:52 +00:00

nalum referenced this issue

2026-08-25 02:21:24 +00:00

test(jobs): pin the make-it-part-of-another-job sheet #237

nalum referenced this issue

2026-08-26 18:47:56 +00:00

Order of work for the jobs flow redesign (#170-#183) #184