eagraiclainne/app

Watch

Fork 0

fix(widget): the seven widgets keep their names through R8 #275

Merged

nalum merged 2 commits from fix/widget-r8-class-merge into main

2026-08-29 17:36:18 +00:00

nalum commented

2026-08-29 17:07:30 +00:00

Owner

Release v2.1.1 on a Pixel: after the first 15-minute beat, the quick add, points and jobs widgets all repaint as the today widget.

Cause. R8 horizontal class merging collapsed five of the seven GlanceAppWidget subclasses into CalendarWidget's obfuscated class (confirmed in the release mapping.txt). Glance maps a receiver's glance ids by the widget class's canonical name (GlanceAppWidgetManager), so one shared name makes getGlanceIds return every placed widget. Each updateAll in WidgetUpdater.updateAllWidgets then painted all of them, and the last writer won. Debug builds do not minify, which is why the drift never showed on the debug install.

Fix. A ProGuard keep on GlanceAppWidget subclasses blocks both the merge and the rename. A fresh release build's mapping shows all seven classes distinct and unrenamed.

Needs a patch release to reach the phone — the placed widgets recover on the first beat after update.

Release v2.1.1 on a Pixel: after the first 15-minute beat, the quick add, points and jobs widgets all repaint as the today widget. **Cause.** R8 horizontal class merging collapsed five of the seven `GlanceAppWidget` subclasses into CalendarWidget's obfuscated class (confirmed in the release `mapping.txt`). Glance maps a receiver's glance ids by the widget class's canonical name (`GlanceAppWidgetManager`), so one shared name makes `getGlanceIds` return every placed widget. Each `updateAll` in `WidgetUpdater.updateAllWidgets` then painted all of them, and the last writer won. Debug builds do not minify, which is why the drift never showed on the debug install. **Fix.** A ProGuard keep on `GlanceAppWidget` subclasses blocks both the merge and the rename. A fresh release build's mapping shows all seven classes distinct and unrenamed. Needs a patch release to reach the phone — the placed widgets recover on the first beat after update.

nalum added 1 commit

2026-08-29 17:07:30 +00:00

fix(widget): the seven widgets keep their names through R8

check / commits (pull_request) Successful in 23s

Details

check / go (pull_request) Successful in 2m49s

Details

check / report (pull_request) Successful in 9s

Details

check / web (pull_request) Successful in 4m26s

Details

android / build (pull_request) Successful in 7m15s

Details

android / report (pull_request) Successful in 4s

Details

c03cb857dc

Release v2.1.1 on the Pixel: after the first 15-minute beat every
placed widget repaints as one of them (the today board). R8's
horizontal class merging had collapsed five of the seven
GlanceAppWidget subclasses into CalendarWidget's class, and Glance
maps a receiver's glance ids by the widget class's canonical name
(GlanceAppWidgetManager) — one shared name means getGlanceIds
returns every placed widget, so each updateAll in
WidgetUpdater.updateAllWidgets painted all of them and the last
writer won. Debug builds never minify, which is why the drift only
shows on release.

A keep on GlanceAppWidget subclasses blocks both the merge and the
rename, so each widget's ids stay its own.

forgejo-actions commented

2026-08-29 17:10:32 +00:00

Test report

Suite	Tests	Result	Skipped
Unit	1440	✅ pass	1
Integration	133	✅ pass	—

Coverage: 27.0%

_{Updated by the check workflow · commit 2bbf6b8487}

## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1440 | ✅ pass | 1 | | Integration | 133 | ✅ pass | — | **Coverage:** 27.0% <sub>Updated by the check workflow · commit 2bbf6b848780601ab6e5381e70c50bb0dd5a9495</sub>

forgejo-actions commented

2026-08-29 17:14:52 +00:00

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	263	✅ pass	1

Coverage: 11.7% of lines

_{Updated by the android workflow · commit 2bbf6b8487}

## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 263 | ✅ pass | 1 | **Coverage:** 11.7% of lines <sub>Updated by the android workflow · commit 2bbf6b848780601ab6e5381e70c50bb0dd5a9495</sub>

nalum added 1 commit

2026-08-29 17:23:15 +00:00

chore(deploy): the Obtainium import ships with every release

check / commits (pull_request) Successful in 19s

Details

check / go (pull_request) Successful in 3m4s

Details

check / report (pull_request) Successful in 11s

Details

android / report (pull_request) Has been cancelled

Details

android / build (pull_request) Has been cancelled

Details

check / web (pull_request) Has been cancelled

Details

cab4468d34

The phone tracks the Forgejo releases for its APK through Obtainium,
but that source config lived only on the device. deploy/obtainium.json
now holds the export (installed-state fields cleared, source settings
kept as exported) and the binaries job copies it into every release as
a versioned asset on the signed checksums, so a fresh device imports
it from the release page and gets the same tracked source, arch filter
and update behaviour as the existing installs.

nalum force-pushed fix/widget-r8-class-merge from cab4468d34

check / commits (pull_request) Successful in 19s

Details

check / go (pull_request) Successful in 3m4s

Details

check / report (pull_request) Successful in 11s

Details

android / report (pull_request) Has been cancelled

Details

android / build (pull_request) Has been cancelled

Details

check / web (pull_request) Has been cancelled