Cleanups: stale UncheckAll proto comment, dead isManager binding #117

New issue

Closed

opened 2026-08-18 10:45:22 +00:00 by nalum · 1 comment

nalum commented

2026-08-18 10:45:22 +00:00

Owner

From the surface parity report (2026-08-18), defects 5 and 6.

Stale proto comment — the comment on UncheckAll still says "ADMIN/MEMBER only". The matrix grants CHILD and the handler carries no role check. The matrix is authoritative; the comment misleads. Where: proto/api/core/v1/item.proto:296 vs pkg/roles/permissions.go:123.
Dead permission binding — Jobs.kt:80 declares isManager (ItemService/Delete) and never uses it.

From the surface parity report (2026-08-18), defects 5 and 6. 1. **Stale proto comment** — the comment on `UncheckAll` still says "ADMIN/MEMBER only". The matrix grants CHILD and the handler carries no role check. The matrix is authoritative; the comment misleads. Where: `proto/api/core/v1/item.proto:296` vs `pkg/roles/permissions.go:123`. 2. **Dead permission binding** — `Jobs.kt:80` declares `isManager` (`ItemService/Delete`) and never uses it.

nalum added the

bug

severity/low

labels

2026-08-18 10:45:22 +00:00

nalum referenced this issue

2026-08-18 11:22:44 +00:00

Order of work for the open backlog (#107–#136) #137

nalum referenced this issue from a commit

2026-08-18 13:20:59 +00:00

chore: true UncheckAll comment, drop dead isManager binding

nalum referenced this issue

2026-08-18 13:21:14 +00:00

fix: Android danger rule, reduced-motion celebrate, cleanups #144

nalum commented

2026-08-18 16:46:45 +00:00

Author

Owner

Delivered in PR #144 (merged): the UncheckAll proto comment now points at the PermissionMatrix (gen regenerated via make proto) and the dead isManager binding in Jobs.kt is gone.

nalum closed this issue

2026-08-18 16:46:45 +00:00