eagraiclainne/app

Watch

Fork 0

fix: Android danger rule, reduced-motion celebrate, cleanups #144

Merged

nalum merged 3 commits from fix/android-defects into main

2026-08-18 16:43:22 +00:00

nalum commented

2026-08-18 13:21:14 +00:00

Owner

Closes #124, #125, #117. PR 6 of the #137 stack, based on #143. Three commits, one per concern.

#124 — honest up-for-grabs rows on Today

The preview rows rendered bare danger-coloured Overdue text — the project rule is danger = icon AND word — while the shared OverdueBadge sat unused beside them. The rows now wear the badge, the worth line gets its star back, and each row is its own tap target opening the Jobs board (the web's per-row links); the card-level click goes so a press has one meaning.

#125 — celebrate stays a state under reduced motion

Reduced motion suppressed the whole celebrate moment — no stamp, no tint, the card just vanished — where the web keeps both as instant states and zeroes only durations. JobStamp now reads its own reduced-motion answer: it snaps to the settled end frame and holds it for the animation's span before retiring. Call sites (Jobs, Today, Rewards claim) always stamp; only the confetti stays gated.

#117 — cleanups

The UncheckAll proto comment claimed "ADMIN/MEMBER only" while the matrix (the authority) grants CHILD — it now points at the PermissionMatrix instead of restating a role list (gen files regenerated). The dead isManager binding in Jobs.kt is gone.

Emulator-verified against the live deploy: the Up-for-grabs row shows the clock-and-word Overdue pill and the starred worth, tapping the row lands on the Jobs board, and with the system animator scale at zero a completed card holds the celebrate tint and settled mark stamp as a static state before retiring. Seeded data cleaned up.

🤖 Generated with Claude Code

Closes #124, #125, #117. PR 6 of the #137 stack, based on #143. Three commits, one per concern. **#124 — honest up-for-grabs rows on Today** The preview rows rendered bare danger-coloured Overdue text — the project rule is danger = icon AND word — while the shared `OverdueBadge` sat unused beside them. The rows now wear the badge, the worth line gets its star back, and each row is its own tap target opening the Jobs board (the web's per-row links); the card-level click goes so a press has one meaning. **#125 — celebrate stays a state under reduced motion** Reduced motion suppressed the whole celebrate moment — no stamp, no tint, the card just vanished — where the web keeps both as instant states and zeroes only durations. `JobStamp` now reads its own reduced-motion answer: it snaps to the settled end frame and holds it for the animation's span before retiring. Call sites (Jobs, Today, Rewards claim) always stamp; only the confetti stays gated. **#117 — cleanups** The `UncheckAll` proto comment claimed "ADMIN/MEMBER only" while the matrix (the authority) grants CHILD — it now points at the PermissionMatrix instead of restating a role list (gen files regenerated). The dead `isManager` binding in `Jobs.kt` is gone. Emulator-verified against the live deploy: the Up-for-grabs row shows the clock-and-word Overdue pill and the starred worth, tapping the row lands on the Jobs board, and with the system animator scale at zero a completed card holds the celebrate tint and settled mark stamp as a static state before retiring. Seeded data cleaned up. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 3 commits

2026-08-18 13:21:14 +00:00

fix(android): honest up-for-grabs rows on Today 61bf6b0e77

The preview rows broke the danger rule — bare danger-coloured Overdue
text with neither icon nor frame — while the shared OverdueBadge sat
unused beside them (#124). The rows now wear the badge, the worth line
gets its star back, and each row is its own tap target opening the Jobs
board, like the web's per-row links; the card-level click goes, so a
row press has one meaning.

fix(android): celebrate stays a state under reduced motion ef2ea60e2e

Reduced motion suppressed the whole celebrate moment — no stamp, no
tint, the card just vanished — where the web keeps stamp and tint as
instant states and zeroes only the durations (#125). The stamp overlay
now reads its own reduced-motion answer: it snaps to the settled end
frame and holds it for the animation's span before retiring, so the
moment still reads as a state, not motion (the same ruling the save
arc follows). Call sites always stamp; only the confetti stays gated.

chore: true UncheckAll comment, drop dead isManager binding

check / commits (pull_request) Successful in 7s

Details

check / web (pull_request) Successful in 1m29s

Details

check / go (pull_request) Successful in 2m37s

Details

check / report (pull_request) Successful in 4s

Details

android / build (pull_request) Successful in 5m18s

Details

android / report (pull_request) Successful in 4s

Details

android / report (push) Has been cancelled

Details

check / commits (push) Has been cancelled

Details

check / go (push) Has been cancelled

Details

check / report (push) Has been cancelled

Details

check / web (push) Has been cancelled

Details

tag / tag (push) Has been cancelled

Details

android / build (push) Has been cancelled

Details

f992b10032

Two cleanups from the parity report (#117). The UncheckAll proto
comment still claimed ADMIN/MEMBER only — the matrix (the authority)
grants CHILD too and the handler carries no role check, so the comment
now points at the matrix instead of restating a stale role list. And
Jobs.kt declared an isManager binding no affordance reads any more —
gone.

nalum referenced this pull request

2026-08-18 13:21:27 +00:00

Order of work for the open backlog (#107–#136) #137

forgejo-actions commented

2026-08-18 13:23:58 +00:00

Test report

Suite	Tests	Result	Skipped
Unit	1370	✅ pass	1
Integration	86	✅ pass	—

Coverage: 28.0%

_{Updated by the check workflow · commit f992b10032}

## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1370 | ✅ pass | 1 | | Integration | 86 | ✅ pass | — | **Coverage:** 28.0% <sub>Updated by the check workflow · commit f992b10032c6254855921ec90c695588907b1918</sub>

forgejo-actions commented

2026-08-18 13:26:39 +00:00

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

Coverage: 2.4% of lines

_{Updated by the android workflow · commit f992b10032}

## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | **Coverage:** 2.4% of lines <sub>Updated by the android workflow · commit f992b10032c6254855921ec90c695588907b1918</sub>

nalum referenced this pull request

2026-08-18 14:08:11 +00:00

refactor: web shared entity components — kill the render forks #145

nalum changed target branch from fix/cli-defects to main

2026-08-18 16:43:16 +00:00

nalum merged commit f992b10032 into main

2026-08-18 16:43:22 +00:00

nalum deleted branch fix/android-defects

2026-08-18 16:43:22 +00:00

nalum referenced this pull request

2026-08-18 16:46:45 +00:00

Cleanups: stale UncheckAll proto comment, dead isManager binding #117