ItemService.Update writes a deadline onto a sub-job #181

New issue

Closed

opened 2026-08-23 19:46:07 +00:00 by nalum · 0 comments

nalum commented

2026-08-23 19:46:07 +00:00

Owner

SetDeadline refuses a deadline on an item that has a parent_uid (internal/services/item/setdeadline.go:35-38, domain.ErrSubTaskDeadline), because a sub-job carries no date and would be invisible on every deadline surface.

Update applies the field with no such check (internal/services/item/update.go:57-59), so the same state is reachable through the other door. Found while reviewing the jobs design handoff, which relies on Update for per-field commits.

The guard belongs on both doors. No client sends it today, so this is a latent hole rather than a live defect — but the new job flow commits fields one at a time through Update, which brings the two doors much closer together.

`SetDeadline` refuses a deadline on an item that has a `parent_uid` (`internal/services/item/setdeadline.go:35-38`, `domain.ErrSubTaskDeadline`), because a sub-job carries no date and would be invisible on every deadline surface. `Update` applies the field with no such check (`internal/services/item/update.go:57-59`), so the same state is reachable through the other door. Found while reviewing the jobs design handoff, which relies on `Update` for per-field commits. The guard belongs on both doors. No client sends it today, so this is a latent hole rather than a live defect — but the new job flow commits fields one at a time through `Update`, which brings the two doors much closer together.

nalum added the

bug

severity/low

labels

2026-08-23 19:46:07 +00:00

nalum referenced this issue

2026-08-23 19:46:30 +00:00

Order of work for the jobs flow redesign (#170-#183) #184

nalum added the

area/server

label

2026-08-23 22:57:18 +00:00