fix(item): refuse a deadline on a step through Update #204

Merged

nalum merged 1 commit from fix/step-deadline-via-update into main 2026-08-26 18:33:04 +00:00

Conversation 2 Commits 1 Files changed 3 +48

nalum commented 2026-08-24 09:16:18 +00:00

Owner

Copy link

Closes #181.

SetDeadline refuses a deadline on an item with a parent_uid — a sub-job
carries no date of its own and would be invisible on every deadline surface
(ADR-0025). Update applied the same field with no such check, so the
forbidden state was reachable through the other door.

No client sends it today. It matters now because the jobs redesign commits
fields one at a time through Update, which brings the two doors much
closer together.

Reuses domain.ErrSubTaskDeadline rather than growing a second error, so
both doors fail identically. Clearing a deadline stays allowed, exactly as
SetDeadline allows it.

🤖 Generated with Claude Code

Closes #181. `SetDeadline` refuses a deadline on an item with a `parent_uid` — a sub-job carries no date of its own and would be invisible on every deadline surface (ADR-0025). `Update` applied the same field with no such check, so the forbidden state was reachable through the other door. No client sends it today. It matters now because the jobs redesign commits fields one at a time through `Update`, which brings the two doors much closer together. Reuses `domain.ErrSubTaskDeadline` rather than growing a second error, so both doors fail identically. Clearing a deadline stays allowed, exactly as `SetDeadline` allows it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-08-24 09:16:18 +00:00

fix(item): refuse a deadline on a step through Update ... d6b2040c6b

SetDeadline already refused a non-empty deadline on an Item with a
parent_uid (ADR-0025: a step never appears on any deadline surface),
but Update applied req.Msg.Deadline unconditionally. Same forbidden
state, second door — no client exercises it today, but the upcoming
per-field-commit redesign drives deadlines through Update, bringing
the two doors together. Reuse domain.ErrSubTaskDeadline via
svc.MapDomainError so both doors fail identically; clearing a
deadline stays allowed on either path.

nalum added the

area/jobs

area/server

enhancement

labels 2026-08-24 09:16:19 +00:00

forgejo-actions commented 2026-08-24 09:44:59 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1375	✅ pass	1
Integration	90	✅ pass	—

Coverage: 26.8%

_{Updated by the check workflow · commit bb59757c42}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1375 | ✅ pass | 1 | | Integration | 90 | ✅ pass | — | **Coverage:** 26.8% _{Updated by the check workflow · commit bb59757c427854947f64e8c335f56b02e073c3c7}

nalum force-pushed fix/step-deadline-via-update from d6b2040c6b to bb59757c42 2026-08-26 07:04:21 +00:00 Compare

forgejo-actions commented 2026-08-26 11:18:58 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	43	✅ pass	0

Coverage: 3.0% of lines

_{Updated by the android workflow · commit bb59757c42}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 43 | ✅ pass | 0 | **Coverage:** 3.0% of lines _{Updated by the android workflow · commit bb59757c427854947f64e8c335f56b02e073c3c7}

nalum changed target branch from docs/occurrence-date-zone to main 2026-08-26 18:32:58 +00:00

nalum merged commit bb59757c42 into main 2026-08-26 18:33:04 +00:00

nalum deleted branch fix/step-deadline-via-update 2026-08-26 18:33:07 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!204

No description provided.