Calendar: creating an event

nalum commented

2026-08-23 22:54:06 +00:00

Owner

Part of the calendar redesign. The design handoff (design_handoff_calendar, held outside the repo) is the source; the facts it depends on are repeated here so this issue stands alone.

The jobs grammar applied: screen one asks what, what kind, when and who; everything the record can live without goes behind More; creating is the only explicit Save.

The shipped form asks nine questions in one scroll and labels six of them (optional), which is the form admitting it should not have asked.

Screen one — title (focused, in the edit treatment, labelled WHAT'S HAPPENING), Kind (chevron, defaults to GENERAL so most events never open it), When (chevron; chips first, then a month grid, then times — today ringed, selection filled, the footer stating the outcome), Runs (daily_times, and only when the event covers more than one day: Runs right through versus Same times each day), Who's going (chevron, multi-select, naming two and counting past that). Footer is More plus Add event.

More, not Next — screen two is optional, so the primary action must be reachable from screen one. Both screens can commit; only one is required.

Behind More: description, Where, Remind, Repeats, and a readback naming the rule, the people and the first date.

Two rules the shipped form breaks:

No Cancel button. The sheet dismisses by drag-down, click-away or Escape, like every other sheet.
No hand-typed dates or times. A YYYY-MM-DD box beside its own picker button is two ways to enter one value, and the typed one is the one that can be wrong.

Mint the uid client-side as a UUIDv7 so an offline replay converges on ALREADY_EXISTS. The device zone rides along on create — and because an unknown zone is InvalidArgument, the offline queue must stamp it at enqueue, never at flush.

Two requirements added after #213 shipped

The job sheet went out to the family's cluster three times before it was right.
Seven visual defects, none caught by a suite: pickers that unfolded forms
instead of opening, three Save buttons on a commit-on-blur screen, (optional)
labels, a reward's name used as a field label, an unstyled add row, checkboxes
with a ghosted tick, and a create form with a browser spinner. Every one had to
be found by a person looking at a screen.

1. Screenshot goldens are part of this ticket

Record gallery (Playwright) and Roborazzi cases for every surface this ticket
builds or visibly changes, and treat them as a deliverable rather than a
follow-up. Three of #213's defects — the unstyled add row, the ghosted
checkboxes, the spinner in the create form — were pixel faults that a golden
would have caught before a deploy did.

#172 deferred its goldens on the reasoning that later tickets would re-record
them. That reasoning was sound then and is not now: the row grammar and the
pickers are settled, so an image recorded here stays valid.

Mechanics, from AGENTS.md: a new case rides in the same commit as the code
that adds it — a commit that adds a gallery or Roborazzi case without its image
is red on its own, because check / web runs npm run test:screens and
android / build runs verifyRoborazziDebug. A re-recorded existing case
goes in its own commit, so the reviewable diff stays code.

2. Check for leaked form styling before you finish

Every visual defect on #213 came from one place: the shipped app's form
fragments reused inside the new row grammar. They pass every test, because the
tests assert the pieces exist rather than that the screen reads right.

Before you call this done, grep the surfaces you touched and report what you
found and what you did about each:

a raw <input> / OutlinedTextField / BasicTextField outside the row and
picker components — a form field dropped into a list of rows
type="number", which renders browser spinner arrows
btn, link-btn, btn-quiet or TextButton where a row or a quiet row
verb belongs — underlined links reading as broken text
(optional) in any label — §8 names that pattern as the form admitting it
should not have asked
any Save button on a surface that commits on blur, including Save changes and Save the points
a disabled-and-grey control where law 5 wants it absent
a record's title used as a field row's label — that column is for a
field's name (Who, When, Worth), and a long title wraps in it

If your ticket is the first to land after this was written, add the check to
AGENTS.md beside the goldens rule, so it stops being a thing I remember to say.

Part of the calendar redesign. The design handoff (`design_handoff_calendar`, held outside the repo) is the source; the facts it depends on are repeated here so this issue stands alone. The jobs grammar applied: screen one asks what, what kind, when and who; everything the record can live without goes behind *More*; creating is the only explicit Save. The shipped form asks nine questions in one scroll and labels six of them *(optional)*, which is the form admitting it should not have asked. **Screen one** — title (focused, in the edit treatment, labelled `WHAT'S HAPPENING`), **Kind** (chevron, defaults to `GENERAL` so most events never open it), **When** (chevron; chips first, then a month grid, then times — today ringed, selection filled, the footer stating the outcome), **Runs** (`daily_times`, and **only when the event covers more than one day**: *Runs right through* versus *Same times each day*), **Who's going** (chevron, multi-select, naming two and counting past that). Footer is `More` plus `Add event`. `More`, not `Next` — screen two is optional, so the primary action must be reachable from screen one. Both screens can commit; only one is required. **Behind More:** description, `Where`, `Remind`, `Repeats`, and a readback naming the rule, the people and the first date. Two rules the shipped form breaks: - **No Cancel button.** The sheet dismisses by drag-down, click-away or Escape, like every other sheet. - **No hand-typed dates or times.** A `YYYY-MM-DD` box beside its own picker button is two ways to enter one value, and the typed one is the one that can be wrong. Mint the uid client-side as a UUIDv7 so an offline replay converges on `ALREADY_EXISTS`. The device zone rides along on create — and because an unknown zone is `InvalidArgument`, the offline queue must stamp it at enqueue, never at flush. --- ## Two requirements added after #213 shipped The job sheet went out to the family's cluster three times before it was right. Seven visual defects, none caught by a suite: pickers that unfolded forms instead of opening, three Save buttons on a commit-on-blur screen, `(optional)` labels, a reward's name used as a field label, an unstyled add row, checkboxes with a ghosted tick, and a create form with a browser spinner. Every one had to be found by a person looking at a screen. ### 1. Screenshot goldens are part of this ticket Record gallery (Playwright) and Roborazzi cases for every surface this ticket builds or visibly changes, and treat them as a deliverable rather than a follow-up. Three of #213's defects — the unstyled add row, the ghosted checkboxes, the spinner in the create form — were pixel faults that a golden would have caught before a deploy did. `#172` deferred its goldens on the reasoning that later tickets would re-record them. That reasoning was sound then and is not now: the row grammar and the pickers are settled, so an image recorded here stays valid. Mechanics, from AGENTS.md: a **new** case rides in the same commit as the code that adds it — a commit that adds a gallery or Roborazzi case without its image is red on its own, because `check / web` runs `npm run test:screens` and `android / build` runs `verifyRoborazziDebug`. A **re-recorded existing** case goes in its own commit, so the reviewable diff stays code. ### 2. Check for leaked form styling before you finish Every visual defect on #213 came from one place: the shipped app's form fragments reused inside the new row grammar. They pass every test, because the tests assert the pieces exist rather than that the screen reads right. Before you call this done, grep the surfaces you touched and report what you found and what you did about each: - a raw `<input>` / `OutlinedTextField` / `BasicTextField` outside the row and picker components — a form field dropped into a list of rows - `type="number"`, which renders browser spinner arrows - `btn`, `link-btn`, `btn-quiet` or `TextButton` where a row or a quiet row verb belongs — underlined links reading as broken text - `(optional)` in any label — §8 names that pattern as the form admitting it should not have asked - **any Save button on a surface that commits on blur**, including `Save changes` and `Save the points` - a disabled-and-grey control where law 5 wants it absent - a record's title used as a field row's `label` — that column is for a field's name (`Who`, `When`, `Worth`), and a long title wraps in it If your ticket is the first to land after this was written, add the check to AGENTS.md beside the goldens rule, so it stops being a thing I remember to say.

nalum added the

enhancement

android

web

labels

2026-08-23 22:54:06 +00:00

nalum referenced this issue

2026-08-23 22:54:30 +00:00

Order of work for the calendar redesign (#187-#198) #199

nalum added the

area/calendar

label

2026-08-23 22:57:22 +00:00

nalum referenced this issue

2026-08-26 00:21:00 +00:00

feat(calendar): the day sheet — untimed first, the axis collapses #261

nalum referenced this issue from a commit

2026-08-26 00:21:00 +00:00

feat(calendar): the day sheet — untimed first, the axis collapses, web

nalum referenced this issue

2026-08-26 03:04:21 +00:00

feat(calendar): creating an event — screen one and More #264

nalum referenced this issue from a commit

2026-08-26 03:04:21 +00:00

feat(calendar): creating an event — screen one and More, web

nalum referenced this issue from a commit

2026-08-26 03:04:21 +00:00

feat(calendar): creating an event — screen one and More, compose twin

nalum commented

2026-08-26 03:24:28 +00:00

Author

Owner

Delivered in PR #264: EventCreateSheet on both surfaces — the focused two-screen create (WHAT'S HAPPENING, kind seeds, When picker, More screen), no Cancel, client-minted uid at enqueue. The old NewEventForm/NewEventSheet retire.

nalum referenced this issue

2026-08-26 03:24:40 +00:00

Order of work for the calendar redesign (#187-#198) #199

nalum referenced this issue from a commit

2026-08-26 03:45:36 +00:00

feat(calendar): the day sheet — untimed first, the axis collapses, web

nalum referenced this issue from a commit

2026-08-26 03:45:49 +00:00

feat(calendar): creating an event — screen one and More, web

nalum referenced this issue from a commit

2026-08-26 03:45:50 +00:00

feat(calendar): creating an event — screen one and More, compose twin