feat(calendar): creating an event — screen one and More #264

Merged

nalum merged 2 commits from feat/calendar-create into main 2026-08-26 18:38:19 +00:00

Conversation 2 Commits 2 Files changed 23 +1427 -1527

nalum commented 2026-08-26 03:04:21 +00:00

Owner

Copy link

Implements #194 on both surfaces.

• Screen one asks four things: the title focused in the edit treatment under WHAT'S HAPPENING, a Kind row defaulting to Just-an-event (each kind carrying its one-line consequence; Birthday seeds all-day + yearly, never locking), the When picker (chips → month grid → All day toggle → Starts/Ends 15-minute lists), a Runs row present only when the event covers more than one day, and Who's going. Everything else — note, Where, Remind, Repeats (with its No chip), and the readback naming the rule, the people and the first date — lives behind More, beside Add event so the primary stays reachable from screen one.
• No Cancel button (the sheet dismisses like every sheet), no hand-typed dates or times anywhere, and the shipped nine-question form (plus its (optional) labels) is gone on both surfaces, its edit mode with it — the event sheet is the editor.
• The uid is client-minted (UUIDv7, the queue's existing mint) so an offline replay converges on ALREADY_EXISTS; the device zone is stamped at enqueue, never at flush.
• Verdict: spans are picked through an always-present Last day row reading Same day until one exists — §4 keeps Runs span-only but leaves the span's door unspecified, and a row whose value names its emptiness is the row grammar's own shape. Form-fragment sweep on the new sheets: no raw inputs outside FieldRow, no number spinners, no (optional), the one Save is the create's own Add event.

Stacked on #263. Design: calendar handoff §4, calendar-demo.dc.html.

🤖 Generated with Claude Code

Implements #194 on both surfaces. - **Screen one asks four things**: the title focused in the edit treatment under `WHAT'S HAPPENING`, a Kind row defaulting to Just-an-event (each kind carrying its one-line consequence; Birthday seeds all-day + yearly, never locking), the When picker (chips → month grid → All day toggle → Starts/Ends 15-minute lists), a Runs row present only when the event covers more than one day, and Who's going. Everything else — note, Where, Remind, Repeats (with its No chip), and the readback naming the rule, the people and the first date — lives behind **More**, beside `Add event` so the primary stays reachable from screen one. - **No Cancel button** (the sheet dismisses like every sheet), **no hand-typed dates or times** anywhere, and the shipped nine-question form (plus its `(optional)` labels) is gone on both surfaces, its edit mode with it — the event sheet is the editor. - The uid is client-minted (UUIDv7, the queue's existing mint) so an offline replay converges on ALREADY_EXISTS; the device zone is stamped at enqueue, never at flush. - **Verdict**: spans are picked through an always-present `Last day` row reading `Same day` until one exists — §4 keeps Runs span-only but leaves the span's door unspecified, and a row whose value names its emptiness is the row grammar's own shape. Form-fragment sweep on the new sheets: no raw inputs outside FieldRow, no number spinners, no `(optional)`, the one Save is the create's own `Add event`. Stacked on #263. Design: calendar handoff §4, calendar-demo.dc.html. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 2 commits 2026-08-26 03:04:21 +00:00

feat(calendar): creating an event — screen one and More, web ... a851ae1879

The jobs grammar applied to events (#194): screen one asks what, what
kind, when and who — the title focused in the edit treatment under
WHAT'S HAPPENING, a Kind row defaulting to Just-an-event so most events
never open it, the When picker (chips, the grid, All day, Starts/Ends),
a Runs row present only when the event covers more than one day, and
Who's going naming two and counting past that. Everything the record
can live without sits behind More — the description with no label and
no box, Where, Remind, Repeats, and a readback naming the rule, the
people and the first date. The footer is More beside Add event: screen
two is optional, so the primary is reachable from screen one. No Cancel
button (the sheet dismisses like every sheet) and no hand-typed dates
or times anywhere in the flow.

The uid is minted client-side (UUIDv7) so an offline replay converges
on ALREADY_EXISTS, and the device zone rides along stamped at enqueue —
an unknown zone is InvalidArgument at flush, which is too late to ask.

Design: calendar handoff §4, calendar-demo.dc.html.

feat(calendar): creating an event — screen one and More, compose twin ... 73415525e1

The Android half of #194: EventCreateSheet replaces the shipped
nine-question form with the two-screen grammar — the focused title
under WHAT'S HAPPENING, Kind, When, the Last-day row naming Same day
until a span exists, Runs only on a span, Who's going; More holds the
note, Where, Remind, Repeats (with the No chip) and the readback.
More beside Add event, no Cancel, no typed dates. The old NewEventSheet
and its edit mode go — the event sheet is the editor now — and the uid
is minted client-side with the zone stamped at enqueue, as before.

Design: calendar handoff §4, calendar-demo.dc.html.

forgejo-actions commented 2026-08-26 03:07:22 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1440	✅ pass	1
Integration	133	✅ pass	—

Coverage: 27.0%

_{Updated by the check workflow · commit 6ce52e222d}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1440 | ✅ pass | 1 | | Integration | 133 | ✅ pass | — | **Coverage:** 27.0% _{Updated by the check workflow · commit 6ce52e222dd85ce6377ff266d8fdcc97da570544}

forgejo-actions commented 2026-08-26 03:09:24 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	193	✅ pass	0

Coverage: 8.9% of lines

_{Updated by the android workflow · commit 6ce52e222d}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 193 | ✅ pass | 0 | **Coverage:** 8.9% of lines _{Updated by the android workflow · commit 6ce52e222dd85ce6377ff266d8fdcc97da570544}

nalum referenced this pull request 2026-08-26 03:23:45 +00:00

feat(calendar): the toolbar regrouped by grammar (#197) #265

nalum referenced this pull request 2026-08-26 03:24:28 +00:00

Calendar: creating an event #194

nalum referenced this pull request 2026-08-26 03:24:40 +00:00

Order of work for the calendar redesign (#187-#198) #199

nalum force-pushed feat/calendar-create from 73415525e1 to 4cc799ab68 2026-08-26 03:45:50 +00:00 Compare

nalum force-pushed feat/calendar-create from 4cc799ab68 to d113279c55 2026-08-26 04:32:46 +00:00 Compare

nalum force-pushed feat/calendar-create from d113279c55 to bb8244d818 2026-08-26 04:56:49 +00:00 Compare

nalum force-pushed feat/calendar-create from bb8244d818 to 80bc8390db 2026-08-26 05:41:12 +00:00 Compare

nalum force-pushed feat/calendar-create from 80bc8390db to a916c42067 2026-08-26 06:16:45 +00:00 Compare

nalum force-pushed feat/calendar-create from a916c42067 to 6ce52e222d 2026-08-26 07:03:19 +00:00 Compare

nalum referenced this pull request 2026-08-26 08:19:54 +00:00

Calendar: golden coverage for the new sheets — event sheet, create, day sheet, pickers #267

nalum referenced this pull request 2026-08-26 11:49:49 +00:00

fix(calendar): the polish round — review fixes and the revised handoff #268

nalum changed target branch from feat/calendar-event-editor to main 2026-08-26 18:38:15 +00:00

nalum merged commit 6ce52e222d into main 2026-08-26 18:38:19 +00:00

nalum deleted branch feat/calendar-create 2026-08-26 18:38:20 +00:00

nalum referenced this pull request 2026-08-26 18:48:00 +00:00

Calendar: creating an event #194

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!264

No description provided.