fix(web): stop the offline strip flashing on Watch stream drops #64

Merged

nalum merged 1 commit from fix/web-offline-strip-flash into main 2026-08-14 16:55:36 +00:00

Conversation 2 Commits 1 Files changed 2 +14 -3

nalum commented 2026-08-14 12:44:02 +00:00

Owner

Copy link

Stops the offline strip flashing for a few seconds when nothing is wrong.

Stops the offline strip flashing for a few seconds when nothing is wrong.

nalum added 1 commit 2026-08-14 12:44:02 +00:00

fix(web): stop the offline strip flashing on Watch stream drops ... 65c0433fca

The change-feed Watch stream is closed by the server or ingress whenever
it sits idle — routine, not a network cut. dataVersions treated every
non-aborted drop as offline evidence, so the strip rose and then cleared
~5s later when the stream redialled: the 2-3s flash the family saw. Ask
reachability to re-probe on a drop instead of asserting offline — a
server that answers the HEAD stays online (no flash), a real cut fails
the probe and raises the strip honestly. Mirrors the Android client,
which already refuses to call a self-cancelled or cycled stream offline.

nalum force-pushed fix/web-offline-strip-flash from 65c0433fca to 4a23211a6a 2026-08-14 12:45:49 +00:00 Compare

nalum changed target branch from main to fix/android-dinner-strip-theme 2026-08-14 12:45:55 +00:00

nalum referenced this pull request 2026-08-14 12:59:57 +00:00

Backlog ordering (tracking) #62

nalum force-pushed fix/web-offline-strip-flash from 4a23211a6a to 82484ce638 2026-08-14 14:16:15 +00:00 Compare

forgejo-actions commented 2026-08-14 14:25:30 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1330	✅ pass	1
Integration	80	✅ pass	—

Coverage: 27.7%

_{Updated by the check workflow · commit 5cce5d14e4}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1330 | ✅ pass | 1 | | Integration | 80 | ✅ pass | — | **Coverage:** 27.7% _{Updated by the check workflow · commit 5cce5d14e45cf802930a590e913e6225227857af}

nalum force-pushed fix/web-offline-strip-flash from 82484ce638 to 5cce5d14e4 2026-08-14 16:03:17 +00:00 Compare

forgejo-actions commented 2026-08-14 16:48:05 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

_{Updated by the android workflow · commit 5cce5d14e4}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | _{Updated by the android workflow · commit 5cce5d14e45cf802930a590e913e6225227857af}

nalum changed target branch from fix/android-dinner-strip-theme to main 2026-08-14 16:55:30 +00:00

nalum merged commit 5cce5d14e4 into main 2026-08-14 16:55:36 +00:00

nalum deleted branch fix/web-offline-strip-flash 2026-08-14 16:55:36 +00:00

nalum referenced this pull request 2026-08-14 16:58:24 +00:00

offline indicator flashing #51

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!64

No description provided.