eagraiclainne/app

Watch

Fork 0

test(ui): record the field row's goldens #212

Closed

nalum wants to merge 1 commit from test/field-row-goldens into feat/field-row

nalum commented

2026-08-24 10:27:43 +00:00

Owner

The pixels for #171, kept out of the component's own diff so the change a
person has to read is 32 files of code rather than 140.

108 images, 54 per surface: nine cases on hearth in light and dark, plus
the canonical editing case across the other eighteen theme families in
both modes. Cases are the four row states, the empty note, a removed
record, and the three snackbar lines — committed, replaced-someone's-
change, and the late conflict notice.

Both surfaces follow the <component>-<case>-<family>-<mode>.png grammar,
so cmd/uigallery pairs them side by side.

🤖 Generated with Claude Code

The pixels for #171, kept out of the component's own diff so the change a person has to read is 32 files of code rather than 140. 108 images, 54 per surface: nine cases on hearth in light and dark, plus the canonical editing case across the other eighteen theme families in both modes. Cases are the four row states, the empty note, a removed record, and the three snackbar lines — committed, replaced-someone's- change, and the late conflict notice. Both surfaces follow the `<component>-<case>-<family>-<mode>.png` grammar, so `cmd/uigallery` pairs them side by side. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit

2026-08-24 10:27:43 +00:00

test(ui): record the field row's goldens

check / commits (pull_request) Successful in 8s

Details

check / go (pull_request) Successful in 2m48s

Details

check / report (pull_request) Successful in 3s

Details

check / web (pull_request) Successful in 4m8s

Details

android / build (pull_request) Successful in 6m20s

Details

android / report (pull_request) Successful in 4s

Details

a4f32ace5c

Both surfaces, nine cases on hearth in light and dark, and the canonical
editing case across the other eighteen families — 54 images each. Kept
apart from the component so the diff that has to be read by a person is
the code, and the diff nobody reads is the pixels.

nalum added the

area/design-system

area/testing

labels

2026-08-24 10:27:44 +00:00

forgejo-actions commented

2026-08-24 10:33:52 +00:00

Test report

Suite	Tests	Result	Skipped
Unit	1434	✅ pass	1
Integration	130	✅ pass	—

Coverage: 27.0%

_{Updated by the check workflow · commit a4f32ace5c}

## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1434 | ✅ pass | 1 | | Integration | 130 | ✅ pass | — | **Coverage:** 27.0% <sub>Updated by the check workflow · commit a4f32ace5cd7177a29b95a1cf30bd3d310f9f5ee</sub>

forgejo-actions commented

2026-08-24 10:36:52 +00:00

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	69	✅ pass	0

Coverage: 10.0% of lines

_{Updated by the android workflow · commit a4f32ace5c}

## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 69 | ✅ pass | 0 | **Coverage:** 10.0% of lines <sub>Updated by the android workflow · commit a4f32ace5cd7177a29b95a1cf30bd3d310f9f5ee</sub>

nalum commented

2026-08-24 11:24:37 +00:00

Author

Owner

Closing: the split was wrong for a new component.

CI proved it — this branch was green and #211 was red on check / web and
android / build. The web job runs npm run test:screens and the android job
runs verifyRoborazziDebug, so the commit that adds 54 new gallery cases per
surface cannot pass without the images those cases compare against.

The repo's "re-record goldens in their own commit" rule is about changing an
existing component: there the code commit still passes, because the old goldens
are already in the tree. A brand-new component has no such fallback, and
splitting it guarantees one red commit in the stack.

The goldens are folded back into #211, which keeps every commit green on its
own.

Closing: the split was wrong for a new component. CI proved it — this branch was green and #211 was red on `check / web` and `android / build`. The web job runs `npm run test:screens` and the android job runs `verifyRoborazziDebug`, so the commit that adds 54 new gallery cases per surface cannot pass without the images those cases compare against. The repo's "re-record goldens in their own commit" rule is about changing an existing component: there the code commit still passes, because the old goldens are already in the tree. A brand-new component has no such fallback, and splitting it guarantees one red commit in the stack. The goldens are folded back into #211, which keeps every commit green on its own.

nalum closed this pull request

2026-08-24 11:24:37 +00:00

nalum referenced this pull request

2026-08-24 11:24:49 +00:00

feat(ui): the field row both redesigns compose from #211