feat(event): an event keeps at least one person #258

Merged

nalum merged 1 commit from feat/last-attendee-guard into main 2026-08-26 18:37:40 +00:00

Conversation 5 Commits 1 Files changed 12 +273 -33

nalum commented 2026-08-25 23:22:25 +00:00

Owner

Copy link

Implements the server half of #257: the last attendee cannot leave — leaving an event, or one occurrence of it, is a delete when you are the only person on it.

• domain.RemoveMember returns the new ErrLastMember (FailedPrecondition, code LAST_MEMBER) when a removal would empty the guest list; the message names delete as the way out. RemoveUser and LeaveOccurrence inherit the guard through that one seam, and on a still-derived slot the refusal lands before the split is minted, so a refused leave costs no permanent detach.
• Update's guest-list rewrite applies the same verdict inline — it may not be the path that empties a list RemoveUser refuses to empty. Create is untouched: a Birthday starts with nobody on it by design.
• ADR-0036 gains the #257 amendment (and its old last-person trade-off paragraph is struck): ownerless events stay admin-only, the state is prevented from arising instead, and the accidental-join consequence is recorded — deleting the child row re-derives the slot, which is the right undo.
• Coverage: domain unit tests, service specs for all three doors (refusal + rollback pinned), and integration specs including the two-attendee leave and the sole-person refusal.

Stacked on #209 (the branch sits on the current stack tip). Design: calendar handoff §0.1 + acceptance checklist, ruled in #257.

🤖 Generated with Claude Code

Implements the server half of #257: the last attendee cannot leave — leaving an event, or one occurrence of it, is a delete when you are the only person on it. - `domain.RemoveMember` returns the new `ErrLastMember` (`FailedPrecondition`, code `LAST_MEMBER`) when a removal would empty the guest list; the message names delete as the way out. `RemoveUser` and `LeaveOccurrence` inherit the guard through that one seam, and on a still-derived slot the refusal lands before the split is minted, so a refused leave costs no permanent detach. - `Update`'s guest-list rewrite applies the same verdict inline — it may not be the path that empties a list `RemoveUser` refuses to empty. `Create` is untouched: a Birthday starts with nobody on it by design. - ADR-0036 gains the #257 amendment (and its old last-person trade-off paragraph is struck): ownerless events stay admin-only, the state is prevented from arising instead, and the accidental-join consequence is recorded — deleting the child row re-derives the slot, which is the right undo. - Coverage: domain unit tests, service specs for all three doors (refusal + rollback pinned), and integration specs including the two-attendee leave and the sole-person refusal. Stacked on #209 (the branch sits on the current stack tip). Design: calendar handoff §0.1 + acceptance checklist, ruled in #257. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-08-25 23:22:25 +00:00

feat(event): an event keeps at least one person ... cf942b30cf

The #257 ruling: the last attendee cannot leave — leaving an event, or
one occurrence of it, is a delete when you are the only person on it.
Without this the last owner's leave orphans the row into the admin-only
state ADR-0036 accepts for household dates, silently and one tap at a
time; refusing at the seam makes the way out explicit instead.

The guard lives in domain.RemoveMember so every remover shares it:
RemoveUser (the parent list), LeaveOccurrence (the materialised child's
own list — a refusal lands before the split is minted, so a refused
leave costs no permanent detach), and Update's guest-list rewrite gets
the same verdict inline. Create stays free to mint attendee-less events
(every Birthday is one); the rule is that a list never returns to empty,
not that it never starts there.

FailedPrecondition, LAST_MEMBER, wording that names delete as the exit.
Widening: none — this narrows. Design: calendar handoff §0.1 and the
acceptance checklist ('The last attendee cannot leave'), ruled in #257.

forgejo-actions commented 2026-08-25 23:25:35 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1440	✅ pass	1
Integration	133	✅ pass	—

Coverage: 27.0%

_{Updated by the check workflow · commit 9eb74cdc74}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1440 | ✅ pass | 1 | | Integration | 133 | ✅ pass | — | **Coverage:** 27.0% _{Updated by the check workflow · commit 9eb74cdc74e4bc52e7b08e112bc71b002ce245e4}

nalum force-pushed feat/last-attendee-guard from cf942b30cf to c6058fe4ec 2026-08-25 23:42:04 +00:00 Compare

nalum referenced this pull request 2026-08-25 23:42:19 +00:00

feat(calendar): the row grammar at calendar scale #259

nalum referenced this pull request 2026-08-26 03:24:26 +00:00

Decide: the event sheet's editability vs ADR-0036's authority split #257

nalum referenced this pull request 2026-08-26 03:24:40 +00:00

Order of work for the calendar redesign (#187-#198) #199

nalum force-pushed feat/last-attendee-guard from c6058fe4ec to 52ff758ea4 2026-08-26 03:45:31 +00:00 Compare

nalum commented 2026-08-26 03:47:50 +00:00

Author

Owner

Copy link

Two base fixes joined this PR's foot after CI caught them overnight: the field-row title-editing goldens now record with a frozen caret (MotionDurationScale zero — the blink phase was a CI coin toss), and the bundled Eagrai Symbols face now covers ＋ U+FF0B by aliasing it onto DejaVu's plus glyph (the calendar's add affordances fell through to host fonts, which diverged between the dev box and the runner). Every branch in the stack re-recorded its calendar page goldens against the bundled glyph.

Two base fixes joined this PR's foot after CI caught them overnight: the field-row title-editing goldens now record with a frozen caret (MotionDurationScale zero — the blink phase was a CI coin toss), and the bundled Eagrai Symbols face now covers ＋ U+FF0B by aliasing it onto DejaVu's plus glyph (the calendar's add affordances fell through to host fonts, which diverged between the dev box and the runner). Every branch in the stack re-recorded its calendar page goldens against the bundled glyph.

forgejo-actions commented 2026-08-26 04:24:34 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	188	✅ pass	0

Coverage: 9.6% of lines

_{Updated by the android workflow · commit 9eb74cdc74}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 188 | ✅ pass | 0 | **Coverage:** 9.6% of lines _{Updated by the android workflow · commit 9eb74cdc74e4bc52e7b08e112bc71b002ce245e4}

nalum force-pushed feat/last-attendee-guard from 52ff758ea4 to ddacd9938c 2026-08-26 04:32:25 +00:00 Compare

nalum commented 2026-08-26 04:33:15 +00:00

Author

Owner

Copy link

Correction to the note above: the U+FF0B alias was abandoned — the identical Chrome-for-Testing build on the runner still fell back to a host font while every local configuration honored the alias, so it could not be trusted. The stack instead writes the three plus strings with ASCII '+' (Atkinson carries it, bundled, pixel-identical on CI), the fonts subset stays its original eight glyphs, and the divergence from the demo's ＋ is recorded in the day-sheet web commit. The frozen-caret fix stands.

Correction to the note above: the U+FF0B alias was abandoned — the identical Chrome-for-Testing build on the runner still fell back to a host font while every local configuration honored the alias, so it could not be trusted. The stack instead writes the three plus strings with ASCII '+' (Atkinson carries it, bundled, pixel-identical on CI), the fonts subset stays its original eight glyphs, and the divergence from the demo's ＋ is recorded in the day-sheet web commit. The frozen-caret fix stands.

nalum force-pushed feat/last-attendee-guard from ddacd9938c to 959af841b6 2026-08-26 04:56:37 +00:00 Compare

nalum force-pushed feat/last-attendee-guard from 959af841b6 to b6961010e7 2026-08-26 05:40:44 +00:00 Compare

nalum force-pushed feat/last-attendee-guard from b6961010e7 to 48cd494eaf 2026-08-26 06:16:34 +00:00 Compare

nalum commented 2026-08-26 06:50:38 +00:00

Author

Owner

Copy link

Restructured per review: the four suite-hardening commits (frozen caret for the field-row goldens, the 24px page-comparator allowance, the scroll-to-top pin, the webhook spec draining to its own delivery) fix defects that predate this stack, so they moved onto the base branch (docs/park-handoff-bundles) rather than riding this PR. This PR is now the guard and its ADR alone. Each wave's golden re-records stay inside the PR whose change required them (#260, #262, #265).

Restructured per review: the four suite-hardening commits (frozen caret for the field-row goldens, the 24px page-comparator allowance, the scroll-to-top pin, the webhook spec draining to its own delivery) fix defects that predate this stack, so they moved onto the base branch (docs/park-handoff-bundles) rather than riding this PR. This PR is now the guard and its ADR alone. Each wave's golden re-records stay inside the PR whose change required them (#260, #262, #265).

nalum force-pushed feat/last-attendee-guard from 48cd494eaf to 9eb74cdc74 2026-08-26 07:03:44 +00:00 Compare

nalum changed target branch from docs/park-handoff-bundles to main 2026-08-26 18:37:37 +00:00

nalum merged commit 9eb74cdc74 into main 2026-08-26 18:37:40 +00:00

nalum deleted branch feat/last-attendee-guard 2026-08-26 18:37:41 +00:00

nalum referenced this pull request 2026-08-26 18:48:04 +00:00

Decide: the event sheet's editability vs ADR-0036's authority split #257

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!258

No description provided.