fix(android): confetti in its own window, over any open sheet #285

Merged

nalum merged 1 commit from fix/android-confetti-window into main 2026-09-12 20:52:10 +00:00

Conversation 2 Commits 1 Files changed 4 +79 -26

nalum commented 2026-09-12 16:26:34 +00:00

Owner

Copy link

Fixes #283. Stacked on #284 — merge that first.

Three celebration defects on the phone:

• A sub-job ticked inside the job sheet handed the moment to its board. The board drew the confetti on its own canvas, under the sheet, which Material hosts in a separate window.
• The calendar page opened the job sheet with no celebrate hook, so a points tick from a calendar row's sheet never burst.
• The wide calendar (week, month, the day sheet) set its confetti origin, but only the phone branch composed the overlay. Those bursts never drew.

ConfettiOverlay now composes into a transparent, touch-through window of its own: a Compose Dialog with the dim, focus and touch flags cleared. It sits above whichever sheet or dialog fired it, the way the web's fixed-position canvas stacks over an open sheet. Origins move to screen coordinates so a burst fired from a sheet's window lands where the tap was. The calendar page wires onCelebrate like the Jobs and Today boards and hosts one overlay for every view.

Verified on the emulator against the e2e server. A points sub-job ticked inside the job sheet raises a third app window on top with NOT_FOCUSABLE NOT_TOUCHABLE and no dim, above the sheet's window, and it retires when the burst ends. Not checked: TalkBack behaviour with the extra window, and the wide-calendar path on a tablet geometry.

🤖 Generated with Claude Code

Fixes #283. Stacked on #284 — merge that first. Three celebration defects on the phone: - A sub-job ticked inside the job sheet handed the moment to its board. The board drew the confetti on its own canvas, under the sheet, which Material hosts in a separate window. - The calendar page opened the job sheet with no celebrate hook, so a points tick from a calendar row's sheet never burst. - The wide calendar (week, month, the day sheet) set its confetti origin, but only the phone branch composed the overlay. Those bursts never drew. `ConfettiOverlay` now composes into a transparent, touch-through window of its own: a Compose Dialog with the dim, focus and touch flags cleared. It sits above whichever sheet or dialog fired it, the way the web's fixed-position canvas stacks over an open sheet. Origins move to screen coordinates so a burst fired from a sheet's window lands where the tap was. The calendar page wires `onCelebrate` like the Jobs and Today boards and hosts one overlay for every view. Verified on the emulator against the e2e server. A points sub-job ticked inside the job sheet raises a third app window on top with `NOT_FOCUSABLE NOT_TOUCHABLE` and no dim, above the sheet's window, and it retires when the burst ends. Not checked: TalkBack behaviour with the extra window, and the wide-calendar path on a tablet geometry. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-09-12 16:26:34 +00:00

fix(android): confetti in its own window, over any open sheet ... fc5275dc2b

Three celebration defects on the phone (issue #283). A sub-job ticked
inside the job sheet handed the moment to its board, and the board drew
the confetti on its own canvas — under the sheet, which Material hosts
in a separate window. The calendar page opened the job sheet with no
celebrate hook at all, so a points tick from a calendar row's sheet
never burst. And the wide calendar (week, month, the day sheet) set
its confetti origin but only the phone branch composed the overlay, so
those bursts never drew either.

ConfettiOverlay now composes into a transparent, touch-through window
of its own (a Compose Dialog with the dim, focus and touch flags
cleared), so it sits above whichever sheet or dialog fired it — the
web's fixed-position canvas, which the DOM stacks over the sheet for
free. Origins move to screen coordinates so a burst fired from a
sheet's window lands where the tap was. The calendar page wires
onCelebrate like the Jobs and Today boards, and hosts one overlay for
every view.

Verified on the emulator against the e2e server: ticking a points
sub-job inside the job sheet raises a third app window on top with
NOT_FOCUSABLE NOT_TOUCHABLE and no dim, above the sheet's window, and
it retires when the burst ends. Two emulator gotchas met on the way:
the seed's admin has reduce_motion on, and an AVD with
animator_duration_scale 0 reads as system reduce-motion — both skip
the confetti by design.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CywUhYM9usURAtwCY9338d

nalum force-pushed fix/android-confetti-window from fc5275dc2b to d709727a95 2026-09-12 16:31:34 +00:00 Compare

forgejo-actions commented 2026-09-12 16:38:18 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1443	✅ pass	1
Integration	133	✅ pass	—

Coverage: 27.0%

_{Updated by the check workflow · commit d709727a95}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1443 | ✅ pass | 1 | | Integration | 133 | ✅ pass | — | **Coverage:** 27.0% _{Updated by the check workflow · commit d709727a95fb7126524ba25b6d4f71b1268ba295}

forgejo-actions commented 2026-09-12 16:39:52 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	275	✅ pass	1

Coverage: 12.5% of lines

_{Updated by the android workflow · commit d709727a95}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 275 | ✅ pass | 1 | **Coverage:** 12.5% of lines _{Updated by the android workflow · commit d709727a95fb7126524ba25b6d4f71b1268ba295}

nalum changed target branch from fix/list-quiet-notifications to main 2026-09-12 20:51:41 +00:00

nalum merged commit d709727a95 into main 2026-09-12 20:52:10 +00:00

nalum deleted branch fix/android-confetti-window 2026-09-12 20:52:14 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!285

No description provided.