feat(web): gate UI affordances on the permission matrix #70

Merged

nalum merged 1 commit from feat/web-affordances-from-matrix into main 2026-08-14 16:56:04 +00:00

Conversation 2 Commits 1 Files changed 11 +167 -37

nalum commented 2026-08-14 14:43:18 +00:00

Owner

Copy link

First part of #61: the web now derives every create/manage affordance from the permission matrix instead of a coarse canEdit flag.

Removes canEdit = ADMIN || MEMBER from the auth context. Adds a permission store (web/src/auth/permissions.ts) that reads SystemService.GetPermissionMatrix (from #69), caches it in localStorage and hydrates synchronously so affordances never flicker, and exposes can(service, method) on the auth context. Every page now gates on the specific verb its control performs.

What this fixes and changes:

• A child now sees the controls the matrix permits: add-job, add-event, and — after #67 — add/manage lists and meals.
• The Meals page splits its old single flag into the library (MealService, child allowed) and the rota board (MealRotaService, member-only), so a child manages dishes but not the cook rota.
• Jobs splits create (ItemService.Create, child allowed) from the manager tier (ItemService.Delete, member-only) — a child is a taker, per ADR-0014.
• Rewards management stays member-and-up; a child never sees grant controls.
• Per-item ownership checks (canEditJob = isManager || owner === me) are untouched.

Canon updated: AGENTS.md and docs/frontend-plan.html now say affordances mirror the matrix (absent only on a real denial), replacing the old "child sees creation affordances absent entirely" wording.

Still to come in #61: the event-edit flow (web) and the Android consumer + event edit.

Verified: make check passes (tsc, web build, Go tests, lingui — no new strings).

Part of #61.

🤖 Generated with Claude Code

First part of #61: the web now derives every create/manage affordance from the permission matrix instead of a coarse `canEdit` flag. Removes `canEdit = ADMIN || MEMBER` from the auth context. Adds a permission store (`web/src/auth/permissions.ts`) that reads `SystemService.GetPermissionMatrix` (from #69), caches it in localStorage and hydrates synchronously so affordances never flicker, and exposes `can(service, method)` on the auth context. Every page now gates on the specific verb its control performs. What this fixes and changes: - A child now sees the controls the matrix permits: add-job, add-event, and — after #67 — add/manage lists and meals. - The Meals page splits its old single flag into the **library** (`MealService`, child allowed) and the **rota board** (`MealRotaService`, member-only), so a child manages dishes but not the cook rota. - Jobs splits create (`ItemService.Create`, child allowed) from the manager tier (`ItemService.Delete`, member-only) — a child is a taker, per ADR-0014. - Rewards management stays member-and-up; a child never sees grant controls. - Per-item ownership checks (`canEditJob = isManager || owner === me`) are untouched. Canon updated: `AGENTS.md` and `docs/frontend-plan.html` now say affordances mirror the matrix (absent only on a real denial), replacing the old "child sees creation affordances absent entirely" wording. Still to come in #61: the event-edit flow (web) and the Android consumer + event edit. Verified: `make check` passes (tsc, web build, Go tests, lingui — no new strings). Part of #61. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-08-14 14:43:18 +00:00

feat(web): gate UI affordances on the permission matrix ... 8d9bfc4385

The web decided every create and manage control from one coarse flag,
canEdit = ADMIN || MEMBER, a client-side guess that hid controls a role
was actually permitted — a child saw no create buttons even for events,
jobs, lists and meals the server allows. Replace canEdit with a
permission store that reads the server's real matrix (GetPermissionMatrix,
cached and hydrated synchronously) and a can(service, method) check, so
every affordance mirrors what the interceptor enforces. The Meals page
splits its old single flag into the meal library (MealService) and the
rota board (MealRotaService), which have different rules. Part of #61.

nalum added the

enhancement

web

labels 2026-08-14 14:43:18 +00:00

forgejo-actions commented 2026-08-14 14:45:55 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1330	✅ pass	1
Integration	83	✅ pass	—

Coverage: 27.7%

_{Updated by the check workflow · commit 6432948912}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1330 | ✅ pass | 1 | | Integration | 83 | ✅ pass | — | **Coverage:** 27.7% _{Updated by the check workflow · commit 6432948912aeef400a92e92d793aa8eb3810af0a}

nalum referenced this pull request 2026-08-14 14:53:00 +00:00

feat(web): edit non-recurring events from the detail sheet #71

nalum referenced this pull request 2026-08-14 15:35:37 +00:00

Backlog ordering (tracking) #62

nalum force-pushed feat/web-affordances-from-matrix from 8d9bfc4385 to 6432948912 2026-08-14 16:03:16 +00:00 Compare

forgejo-actions commented 2026-08-14 16:47:14 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

_{Updated by the android workflow · commit 6432948912}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | _{Updated by the android workflow · commit 6432948912aeef400a92e92d793aa8eb3810af0a}

nalum changed target branch from feat/permission-matrix-rpc to main 2026-08-14 16:55:56 +00:00

nalum merged commit 6432948912 into main 2026-08-14 16:56:04 +00:00

nalum deleted branch feat/web-affordances-from-matrix 2026-08-14 16:56:04 +00:00

nalum referenced this pull request 2026-08-14 16:58:25 +00:00

Drive UI create/manage/edit affordances off the permission matrix (web + Android) #61

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!70

No description provided.