feat(web): edit non-recurring events from the detail sheet #71

Merged

nalum merged 1 commit from feat/web-event-edit into main 2026-08-14 16:56:10 +00:00

Conversation 2 Commits 1 Files changed 16 +186 -16

nalum commented 2026-08-14 14:53:00 +00:00

Owner

Copy link

Second part of #61: events become editable in the web UI.

EventService.Update existed but no client called it, so an event was create-only — a member could not fix its name, time, guests or description afterward. This adds an Edit action to the event detail sheet that reopens the create form prefilled and saves through events.update.

• The form (NewEventForm) now takes an optional edit event: eventToForm reverses an event back into the form fields (the inverse of submit's encoding), and submit branches to events.update when editing.
• The Edit affordance is gated on can("EventService", "Update") — the matrix source from #70 — so it appears for exactly the permitted roles (including a child, who may edit events).
• mutate.events.update added to the offline queue layer.

Scope — non-recurring events only. Editing a recurring series or a single occurrence needs the split-then-update dance and is deferred, the same way repeat-rule editing already is; UpdateEventRequest carries no repeat field, and the caller withholds the Edit affordance for series parents and projected occurrences. The repeat control is hidden in edit mode.

Remaining in #61: the occurrence-vs-series edit flow, and the Android consumer + Android event edit.

Verified: make check passes (tsc, web build, Go tests, and the web + Android i18n catalogs synced for the new strings).

Part of #61.

🤖 Generated with Claude Code

Second part of #61: events become editable in the web UI. `EventService.Update` existed but no client called it, so an event was create-only — a member could not fix its name, time, guests or description afterward. This adds an **Edit** action to the event detail sheet that reopens the create form prefilled and saves through `events.update`. - The form (`NewEventForm`) now takes an optional `edit` event: `eventToForm` reverses an event back into the form fields (the inverse of submit's encoding), and submit branches to `events.update` when editing. - The Edit affordance is gated on `can("EventService", "Update")` — the matrix source from #70 — so it appears for exactly the permitted roles (including a child, who may edit events). - `mutate.events.update` added to the offline queue layer. **Scope — non-recurring events only.** Editing a recurring series or a single occurrence needs the split-then-update dance and is deferred, the same way repeat-rule editing already is; `UpdateEventRequest` carries no repeat field, and the caller withholds the Edit affordance for series parents and projected occurrences. The repeat control is hidden in edit mode. Remaining in #61: the occurrence-vs-series edit flow, and the Android consumer + Android event edit. Verified: `make check` passes (tsc, web build, Go tests, and the web + Android i18n catalogs synced for the new strings). Part of #61. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-08-14 14:53:00 +00:00

feat(web): edit non-recurring events from the detail sheet ... ac016427df

Events were create-only in the UI — EventService.Update existed but no
client called it, so a member could not fix an event's name, time or
guests after creating it. Add an Edit affordance to the event detail
sheet that reopens the create form prefilled and saves through
events.update. Gated on can(EventService, Update), so it appears for
exactly the roles the matrix permits. Scoped to non-recurring events:
editing a recurring series or one occurrence needs the split-then-update
dance and is deferred to a follow-up, the same way repeat-rule editing
already is. Part of #61.

nalum added the

enhancement

web

labels 2026-08-14 14:53:01 +00:00

forgejo-actions commented 2026-08-14 14:55:38 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1330	✅ pass	1
Integration	83	✅ pass	—

Coverage: 27.7%

_{Updated by the check workflow · commit 82549918d5}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1330 | ✅ pass | 1 | | Integration | 83 | ✅ pass | — | **Coverage:** 27.7% _{Updated by the check workflow · commit 82549918d54b5487000d8206f19aae40b097c847}

nalum referenced this pull request 2026-08-14 15:26:29 +00:00

feat(android): edit non-recurring events from the detail sheet #73

nalum referenced this pull request 2026-08-14 15:35:03 +00:00

feat: edit recurring events, this-one or the whole series #74

nalum referenced this pull request 2026-08-14 15:35:37 +00:00

Backlog ordering (tracking) #62

nalum force-pushed feat/web-event-edit from ac016427df to 82549918d5 2026-08-14 16:03:16 +00:00 Compare

forgejo-actions commented 2026-08-14 16:47:37 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

_{Updated by the android workflow · commit 82549918d5}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | _{Updated by the android workflow · commit 82549918d54b5487000d8206f19aae40b097c847}

nalum changed target branch from feat/web-affordances-from-matrix to main 2026-08-14 16:56:04 +00:00

nalum merged commit 82549918d5 into main 2026-08-14 16:56:10 +00:00

nalum deleted branch feat/web-event-edit 2026-08-14 16:56:10 +00:00

nalum referenced this pull request 2026-08-14 16:58:25 +00:00

Drive UI create/manage/edit affordances off the permission matrix (web + Android) #61

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!71

No description provided.