ci(android): run on every PR and report test results #75

Merged

nalum merged 1 commit from ci/android-run-on-all-prs into main 2026-08-14 16:01:41 +00:00

Conversation 2 Commits 1 Files changed 1 +79 -3

nalum commented 2026-08-14 15:41:41 +00:00

Owner

Copy link

Two gaps on the android workflow.

1. It never ran on stacked PRs. The pull_request trigger was filtered to branches: [main], so it only fired for PRs based on main. The event-editing stack (#72/#73/#74) targets parent feature branches, so the android build, unit tests and gen/android drift check were silently skipped — even though the PRs are labelled android. check.yml already dropped this filter for the same reason (its comment says android.yml mirrors it — it did not). Removed; the paths filter still gates the SDK/Gradle cost.

2. It ran tests but reported nothing. Forgejo has no Checks API, so — like check.yml's report job — the numbers have to reach the PR as a comment. The build job now aggregates the JUnit XML (debug variant, to avoid double-counting the release variant) into pass/fail/skipped totals, and a report job upserts one sticky <!-- android-test-report --> comment per PR. always(), so a failing suite still reports; the build job's red status stays the merge gate.

Self-validating: targets main and edits android.yml, so the android workflow runs on this PR — watch for the report comment.

🤖 Generated with Claude Code

Two gaps on the android workflow. **1. It never ran on stacked PRs.** The `pull_request` trigger was filtered to `branches: [main]`, so it only fired for PRs based on `main`. The event-editing stack (#72/#73/#74) targets parent feature branches, so the android build, unit tests and `gen/android` drift check were silently skipped — even though the PRs are labelled `android`. `check.yml` already dropped this filter for the same reason (its comment says android.yml mirrors it — it did not). Removed; the `paths` filter still gates the SDK/Gradle cost. **2. It ran tests but reported nothing.** Forgejo has no Checks API, so — like `check.yml`'s `report` job — the numbers have to reach the PR as a comment. The build job now aggregates the JUnit XML (debug variant, to avoid double-counting the release variant) into pass/fail/skipped totals, and a `report` job upserts one sticky `<!-- android-test-report -->` comment per PR. `always()`, so a failing suite still reports; the build job's red status stays the merge gate. Self-validating: targets `main` and edits `android.yml`, so the android workflow runs on this PR — watch for the report comment. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-08-14 15:41:41 +00:00

ci(android): run the android checks on every pull request ... e000529633

android.yml's pull_request trigger was filtered to branches: [main], so
it never ran on stacked PRs (whose base is a parent feature branch) —
the android build, unit tests and gen/android drift check were silently
skipped on the whole event-editing stack. check.yml already dropped this
filter for exactly this reason; align android.yml with it. Path filters
still gate the SDK/Gradle cost to android-touching changes.

forgejo-actions commented 2026-08-14 15:44:53 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1330	✅ pass	1
Integration	80	✅ pass	—

Coverage: 27.7%

_{Updated by the check workflow · commit c29d23aa6a}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1330 | ✅ pass | 1 | | Integration | 80 | ✅ pass | — | **Coverage:** 27.7% _{Updated by the check workflow · commit c29d23aa6aed65d25c6cbc7605f3c20d1f5abd23}

nalum force-pushed ci/android-run-on-all-prs from e000529633 to c29d23aa6a 2026-08-14 15:50:13 +00:00 Compare

nalum changed title from ci(android): run the android checks on every pull request to ci(android): run on every PR and report test results 2026-08-14 15:50:28 +00:00

nalum added the

android

ci

labels 2026-08-14 15:50:28 +00:00

nalum referenced this pull request 2026-08-14 15:54:34 +00:00

Add JaCoCo coverage to the Android CI report #76

forgejo-actions commented 2026-08-14 15:58:57 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

_{Updated by the android workflow · commit c29d23aa6a}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | _{Updated by the android workflow · commit c29d23aa6aed65d25c6cbc7605f3c20d1f5abd23}

nalum merged commit c29d23aa6a into main 2026-08-14 16:01:41 +00:00

nalum deleted branch ci/android-run-on-all-prs 2026-08-14 16:01:41 +00:00

nalum referenced this pull request 2026-08-14 16:58:40 +00:00

Backlog ordering (tracking) #62

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!75

No description provided.