eagraiclainne/app

Watch

Fork 0

fix(item): keep list entries out of the notification stream #284

Merged

nalum merged 1 commit from fix/list-quiet-notifications into main

2026-09-12 20:51:38 +00:00

nalum commented

2026-09-12 16:26:33 +00:00

Owner

Fixes #281.

Ticking a list entry rang the family's JOB_COMPLETED bell as if a chore had been done. Create and AssignUser already keep list entries quiet. CompleteItem was the one announcement without the standalone guard, and the due-reminder ticker would ring for a list entry that carried a deadline.

Both now check for a list ref, so lists and their entries send nothing. Specs cover the three cases: a standalone job still announces, a list entry stays silent, a dated list entry does not ring.

Server-only change. No client surface sends these, so parity holds.

🤖 Generated with Claude Code

Fixes #281. Ticking a list entry rang the family's JOB_COMPLETED bell as if a chore had been done. Create and AssignUser already keep list entries quiet. CompleteItem was the one announcement without the standalone guard, and the due-reminder ticker would ring for a list entry that carried a deadline. Both now check for a list ref, so lists and their entries send nothing. Specs cover the three cases: a standalone job still announces, a list entry stays silent, a dated list entry does not ring. Server-only change. No client surface sends these, so parity holds. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit

2026-09-12 16:26:33 +00:00

fix(item): keep list entries out of the notification stream

check / commits (pull_request) Successful in 26s

Details

check / go (pull_request) Successful in 2m59s

Details

check / report (pull_request) Has been cancelled

Details

check / web (pull_request) Has been cancelled

Details

1e1af1a278

Ticking a list entry rang the family's JOB_COMPLETED bell as if a chore
had been done. Create and AssignUser already keep list entries quiet;
CompleteItem was the one announcement without the standalone guard,
and the due-reminder ticker would ring for a list entry that carried a
deadline. Both now check for a list ref, so lists and their entries
send nothing (issue #281).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CywUhYM9usURAtwCY9338d

nalum referenced this pull request

2026-09-12 16:26:34 +00:00

fix(android): confetti in its own window, over any open sheet #285

nalum force-pushed fix/list-quiet-notifications from 1e1af1a278

check / commits (pull_request) Successful in 26s

Details

check / go (pull_request) Successful in 2m59s

Details

check / report (pull_request) Has been cancelled

Details

check / web (pull_request) Has been cancelled

Details

to fc396db762

check / commits (pull_request) Successful in 37s

Details

check / go (pull_request) Successful in 2m56s

Details

check / web (pull_request) Successful in 4m42s

Details

check / report (pull_request) Successful in 4s

Details

check / report (push) Has been cancelled

Details

tag / tag (push) Has been cancelled

Details

check / go (push) Has been cancelled

Details

check / web (push) Has been cancelled

Details

check / commits (push) Has been cancelled

Details

2026-09-12 16:31:35 +00:00

Compare

forgejo-actions commented

2026-09-12 16:38:12 +00:00

Test report

Suite	Tests	Result	Skipped
Unit	1443	✅ pass	1
Integration	133	✅ pass	—

Coverage: 27.0%

_{Updated by the check workflow · commit fc396db762}

## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1443 | ✅ pass | 1 | | Integration | 133 | ✅ pass | — | **Coverage:** 27.0% <sub>Updated by the check workflow · commit fc396db762f069a847181be0ce9893a60a5a12dd</sub>

nalum merged commit fc396db762 into main

2026-09-12 20:51:38 +00:00

nalum deleted branch fix/list-quiet-notifications

2026-09-12 20:51:41 +00:00