feat(authz): let children run shared lists and meals #67

Merged

nalum merged 1 commit from feat/child-shared-containers into main 2026-08-14 16:55:50 +00:00

Conversation 2 Commits 1 Files changed 7 +262 -42

nalum commented 2026-08-14 13:36:47 +00:00

Owner

Copy link

Backend half of #56: admit the child role to the two ownerless shared container services.

Lists and meals have no owner field — unlike jobs, there is nothing to scope a child to. Treating their manager verbs as adult-only was the wrong model, so this admits CHILD to the full verb set of both services, the same rights a member holds:

• ItemListService: Create, Update, Delete, UncheckAll
• MealService: Create, Update, Delete, PushIngredients

Rewards stay member-and-up (a child claims, never grants). The meal rota board is untouched. No schema change — enforcement stays at the interceptor role gate.

Decision recorded in ADR-0028. A new end-to-end integration test drives a real child token through the interceptor to create, edit and delete a list and a meal, with a negative guard proving the token is genuinely child-scoped (reward-create still denied).

Part of #56 (backend). The UI affordance migration (canEdit → matrix) that surfaces these rights in the clients is tracked separately in #61.

Verified: make check and the integration suite pass.

🤖 Generated with Claude Code

Backend half of #56: admit the child role to the two ownerless shared container services. Lists and meals have no owner field — unlike jobs, there is nothing to scope a child to. Treating their manager verbs as adult-only was the wrong model, so this admits CHILD to the full verb set of both services, the same rights a member holds: - `ItemListService`: Create, Update, Delete, UncheckAll - `MealService`: Create, Update, Delete, PushIngredients Rewards stay member-and-up (a child claims, never grants). The meal rota board is untouched. No schema change — enforcement stays at the interceptor role gate. Decision recorded in ADR-0028. A new end-to-end integration test drives a real child token through the interceptor to create, edit and delete a list and a meal, with a negative guard proving the token is genuinely child-scoped (reward-create still denied). Part of #56 (backend). The UI affordance migration (`canEdit` → matrix) that surfaces these rights in the clients is tracked separately in #61. Verified: `make check` and the integration suite pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-08-14 13:36:48 +00:00

feat(authz): let children run shared lists and meals ... 9ed50a914d

Lists and meals are ownerless shared containers — unlike items, there is
no owner to scope a child to. Treating their manager verbs as adult-only
was the wrong model: a child is a trusted member of the household for the
family's shared lists and meal library. Admit CHILD to the full
ItemListService and MealService verb set (create, rename, delete,
uncheck-all; create, edit, delete, push-ingredients), the same rights a
member already holds. Rewards stay member-and-up (a child claims, never
grants); the meal rota board is untouched here. ADR-0028.

nalum added the

enhancement

adr

labels 2026-08-14 13:37:05 +00:00

nalum force-pushed feat/child-shared-containers from 9ed50a914d to 403e2a6096 2026-08-14 14:16:14 +00:00 Compare

forgejo-actions commented 2026-08-14 14:23:41 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1330	✅ pass	1
Integration	83	✅ pass	—

Coverage: 27.7%

_{Updated by the check workflow · commit 53d78cb549}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1330 | ✅ pass | 1 | | Integration | 83 | ✅ pass | — | **Coverage:** 27.7% _{Updated by the check workflow · commit 53d78cb5493a2234dc08b06cd3b11ea4d6c0bf9c}

nalum referenced this pull request 2026-08-14 14:32:52 +00:00

Drive UI create/manage/edit affordances off the permission matrix (web + Android) #61

nalum referenced this pull request 2026-08-14 14:33:17 +00:00

Child role: backend rights for list/meal management + expose the permission matrix #56

nalum referenced this pull request 2026-08-14 14:34:23 +00:00

Backlog ordering (tracking) #62

nalum referenced this pull request 2026-08-14 14:43:18 +00:00

feat(web): gate UI affordances on the permission matrix #70

nalum force-pushed feat/child-shared-containers from 403e2a6096 to 53d78cb549 2026-08-14 16:03:15 +00:00 Compare

forgejo-actions commented 2026-08-14 16:46:46 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

_{Updated by the android workflow · commit 53d78cb549}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | _{Updated by the android workflow · commit 53d78cb5493a2234dc08b06cd3b11ea4d6c0bf9c}

nalum changed target branch from fix/android-nav-labels-one-line to main 2026-08-14 16:55:42 +00:00

nalum merged commit 53d78cb549 into main 2026-08-14 16:55:50 +00:00

nalum deleted branch feat/child-shared-containers 2026-08-14 16:55:50 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!67

No description provided.