feat(android): gate affordances on the permission matrix #72

Merged

nalum merged 1 commit from feat/android-affordances-from-matrix into main 2026-08-14 16:56:17 +00:00

Conversation 2 Commits 1 Files changed 9 +143 -21

nalum commented 2026-08-14 15:14:19 +00:00

Owner

Copy link

Third part of #61: Android gates affordances on the permission matrix, matching the web.

Android decided create/manage controls from MemberRow.manager — a flat Admin || Member derived from the roles string, the same coarse guess the web carried. It hid controls a role was actually permitted, so a child saw no create buttons even for events, jobs, lists and meals the server allows.

• New Permissions store (data module) reads the server matrix (GetPermissionMatrix, from #69), caches it in SharedPreferences and hydrates synchronously on start (honest offline), and exposes check(matrix, service, method, roles). It keys on prettified role names, the same shape MemberRow.roles carries, so no enum plumbing reaches the UI.
• Graph fetches the matrix per session; the composables collect it and gate each affordance on the specific verb it performs.
• Splits mirror the web: Meals into the library (MealService, child) and rota (MealRotaService, member-only); jobs into create (ItemService.Create, child) and the manager tier (ItemService.Delete, member-only). Lists and events admit the child role; rewards stay member-and-up. Per-item ownership checks (canEditJob, canConvert) are untouched.
• The now-dead MemberRow.manager property is removed.

Android event editing is deferred to a follow-up (commit D), the same way recurring-event edit is.

Verified: make check passes (:app and :data compile, Go tests, web build, i18n — no new strings).

Part of #61.

🤖 Generated with Claude Code

Third part of #61: Android gates affordances on the permission matrix, matching the web. Android decided create/manage controls from `MemberRow.manager` — a flat `Admin || Member` derived from the roles string, the same coarse guess the web carried. It hid controls a role was actually permitted, so a child saw no create buttons even for events, jobs, lists and meals the server allows. - New `Permissions` store (data module) reads the server matrix (`GetPermissionMatrix`, from #69), caches it in SharedPreferences and hydrates synchronously on start (honest offline), and exposes `check(matrix, service, method, roles)`. It keys on prettified role names, the same shape `MemberRow.roles` carries, so no enum plumbing reaches the UI. - Graph fetches the matrix per session; the composables collect it and gate each affordance on the specific verb it performs. - Splits mirror the web: Meals into the library (`MealService`, child) and rota (`MealRotaService`, member-only); jobs into create (`ItemService.Create`, child) and the manager tier (`ItemService.Delete`, member-only). Lists and events admit the child role; rewards stay member-and-up. Per-item ownership checks (`canEditJob`, `canConvert`) are untouched. - The now-dead `MemberRow.manager` property is removed. Android event editing is deferred to a follow-up (commit D), the same way recurring-event edit is. Verified: `make check` passes (`:app` and `:data` compile, Go tests, web build, i18n — no new strings). Part of #61. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 1 commit 2026-08-14 15:14:19 +00:00

feat(android): gate affordances on the permission matrix ... feed0393f3

Android decided create and manage controls from MemberRow.manager, a flat
'Admin || Member' derived from the roles string — the same coarse guess
the web carried, hiding controls a role is actually permitted (a child saw
none). Add a Permissions store that reads the server's matrix
(GetPermissionMatrix, cached and hydrated on start) and a check() that
gates each affordance on the specific verb it performs, mirroring the web.
Meals splits into the library (MealService) and rota (MealRotaService);
jobs split create (ItemService.Create, child) from the manager tier
(ItemService.Delete). Android event editing follows separately. Part of #61.

nalum added the

enhancement

android

labels 2026-08-14 15:14:20 +00:00

forgejo-actions commented 2026-08-14 15:16:59 +00:00

Copy link

Test report

Suite	Tests	Result	Skipped
Unit	1330	✅ pass	1
Integration	83	✅ pass	—

Coverage: 27.7%

_{Updated by the check workflow · commit 5f37ec9703}

<!-- ci-test-report --> ## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1330 | ✅ pass | 1 | | Integration | 83 | ✅ pass | — | **Coverage:** 27.7% _{Updated by the check workflow · commit 5f37ec9703177e96186c9108383dc556c234ee9d}

nalum referenced this pull request 2026-08-14 15:35:37 +00:00

Backlog ordering (tracking) #62

nalum force-pushed feat/android-affordances-from-matrix from feed0393f3 to 5f37ec9703 2026-08-14 16:03:14 +00:00 Compare

forgejo-actions commented 2026-08-14 16:45:33 +00:00

Copy link

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

_{Updated by the android workflow · commit 5f37ec9703}

<!-- android-test-report --> ## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | _{Updated by the android workflow · commit 5f37ec9703177e96186c9108383dc556c234ee9d}

nalum changed target branch from feat/web-event-edit to main 2026-08-14 16:56:10 +00:00

nalum merged commit 5f37ec9703 into main 2026-08-14 16:56:17 +00:00

nalum deleted branch feat/android-affordances-from-matrix 2026-08-14 16:56:17 +00:00

nalum referenced this pull request 2026-08-14 16:58:25 +00:00

Drive UI create/manage/edit affordances off the permission matrix (web + Android) #61

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

adr

Needs or introduces an Architecture Decision Record

  

android

affects android app

  

area/calendar

The calendar surfaces: month, week, agenda, day sheet, events

  

area/design-system

Tokens, shared components and the row grammar both surfaces use

  

area/i18n

Strings, msgids and translation across surfaces

  

area/jobs

The jobs surface: board, card, sheet, create

  

area/offline

The offline write queue and sync behaviour

  

area/server

Server behaviour: RPCs, guards, domain rules, proto

  

area/testing

Conformance fixtures, goldens and test harnesses

  

bug

Something is not working

  

ci

CI and release pipeline

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

notifications

Push and notification system

  

question

More information is needed

  

reliability

Robustness, failure modes, resilience

  

security

Security finding or hardening work

  

severity/low

Low severity

  

severity/medium

Medium severity

  

tracking

Plan / tracking issues

  

web

affects web app

  

wontfix

This won't be fixed

No labels

adr

android

area/calendar

area/design-system

area/i18n

area/jobs

area/offline

area/server

area/testing

bug

ci

duplicate

enhancement

help wanted

invalid

notifications

question

reliability

security

severity/low

severity/medium

tracking

web

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

eagraiclainne/app!72

No description provided.