eagraiclainne/app

Watch

Fork 0

feat(notify): event added and cancelled notifications #90

Merged

nalum merged 3 commits from feat/event-notifications into main

2026-08-16 12:41:12 +00:00

nalum commented

2026-08-16 12:29:22 +00:00

Owner

Stacked on #89 (merge order: #88 then #89 then this; Forgejo retargets as parents land).

Events were the one member-facing surface with no emissions at all — being added to an event or having one cancelled reached nobody's phone. Two kinds close it:

EVENT_ADDED tells a member someone put them on an event: at Create for everyone on the prototype, at AddUser for the one added. Never the actor themselves, and never on the idempotent re-add.
EVENT_CANCELLED tells the event's members — not the household — that the series was deleted or one occurrence cancelled (message carries the date). The actor is skipped, and an already-cancelled occurrence stays quiet.

Deliberately silent, recorded here as decisions: RemoveUser (being dropped from a plan is the organiser's conversation, not a push) and Update (noise).

Mechanics follow the existing shape: EventServer gains the notify seam the item server carries, emissions are post-commit best-effort, the webhook decorator forwards both as notify.event_* semantic events, messages are localized server-side (en + ga), and both kinds join the web push-preference checkboxes, the synced kind list, and the Android per-kind channels.

Verified against the live deploy on a real phone: invited to an event → "Stream Test added you to “Notification test picnic”" banner within seconds; event deleted → "Stream Test cancelled …" banner. make check green, Android build green.

🤖 Generated with Claude Code

Stacked on #89 (merge order: #88 then #89 then this; Forgejo retargets as parents land). Events were the one member-facing surface with no emissions at all — being added to an event or having one cancelled reached nobody's phone. Two kinds close it: - **EVENT_ADDED** tells a member someone put them on an event: at `Create` for everyone on the prototype, at `AddUser` for the one added. Never the actor themselves, and never on the idempotent re-add. - **EVENT_CANCELLED** tells the event's members — not the household — that the series was deleted or one occurrence cancelled (message carries the date). The actor is skipped, and an already-cancelled occurrence stays quiet. Deliberately silent, recorded here as decisions: `RemoveUser` (being dropped from a plan is the organiser's conversation, not a push) and `Update` (noise). Mechanics follow the existing shape: `EventServer` gains the notify seam the item server carries, emissions are post-commit best-effort, the webhook decorator forwards both as `notify.event_*` semantic events, messages are localized server-side (en + ga), and both kinds join the web push-preference checkboxes, the synced kind list, and the Android per-kind channels. Verified against the live deploy on a real phone: invited to an event → "Stream Test added you to “Notification test picnic”" banner within seconds; event deleted → "Stream Test cancelled …" banner. `make check` green, Android build green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nalum added 3 commits

2026-08-16 12:29:22 +00:00

feat(notify): tell members about event adds and cancellations db639b59a3

Events were the one member-facing surface with no emissions at all:
being added to an event, an event deleted, an occurrence cancelled —
all silent on every device. Two kinds close it. EVENT_ADDED tells the
member someone put them on an event (at Create for everyone on the
prototype, at AddUser for the one added — never the actor themselves).
EVENT_CANCELLED tells the event's members, except the actor, that the
series was deleted or one date cancelled. RemoveUser stays silent on
purpose — being dropped from a plan is the organiser's conversation to
have, not a push notification; Update stays silent as noise.

The EventServer gains the notify seam the item server already carries;
emissions are post-commit and best-effort as everywhere else.

feat(web): surface the event notification kinds 265f1ba126

The two new kinds join the push-preference checkboxes and the synced
kind list — a kind missing from PUSH_KINDS is stripped from the stored
preference on the next settings write, so every new NotificationKind
must join.

feat(android): notification channels for the event kinds

check / commits (pull_request) Successful in 5s

Details

check / web (pull_request) Successful in 1m33s

Details

check / go (pull_request) Successful in 2m36s

Details

check / report (pull_request) Successful in 3s

Details

android / build (pull_request) Successful in 5m25s

Details

android / report (pull_request) Successful in 3s

Details

93fcf921d9

One channel per kind, as ever — the phone's own per-channel switches
line up with the two new server kinds.

forgejo-actions commented

2026-08-16 12:32:03 +00:00

Test report

Suite	Tests	Result	Skipped
Unit	1332	✅ pass	1
Integration	83	✅ pass	—

Coverage: 27.7%

_{Updated by the check workflow · commit 93fcf921d9}

## Test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit | 1332 | ✅ pass | 1 | | Integration | 83 | ✅ pass | — | **Coverage:** 27.7% <sub>Updated by the check workflow · commit 93fcf921d9e463272bcfd6c5ca3c1ac61f2046ad</sub>

nalum referenced this pull request

2026-08-16 12:32:13 +00:00

notify: job deadline reminders #91

nalum referenced this pull request

2026-08-16 12:32:13 +00:00

notify: tell the family when a new member joins #92

nalum referenced this pull request

2026-08-16 12:32:13 +00:00

notify: steps added to a job you own #93

nalum referenced this pull request

2026-08-16 12:32:13 +00:00

notify: event time/date changes #94

nalum referenced this pull request

2026-08-16 12:32:13 +00:00

notify: shared-list activity #95

forgejo-actions commented

2026-08-16 12:34:51 +00:00

Android test report

Suite	Tests	Result	Skipped
Unit (debug)	31	✅ pass	0

_{Updated by the android workflow · commit 93fcf921d9}

## Android test report | Suite | Tests | Result | Skipped | | --- | --: | --- | --: | | Unit (debug) | 31 | ✅ pass | 0 | <sub>Updated by the android workflow · commit 93fcf921d9e463272bcfd6c5ca3c1ac61f2046ad</sub>

nalum force-pushed feat/event-notifications from 93fcf921d9

check / commits (pull_request) Successful in 5s

Details

check / web (pull_request) Successful in 1m33s

Details

check / go (pull_request) Successful in 2m36s

Details

check / report (pull_request) Successful in 3s

Details

android / build (pull_request) Successful in 5m25s

Details

android / report (pull_request) Successful in 3s